github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

add ember-script support #179

Open
heartsentwined wants to merge 1 commits from heartsentwined/ember-script into master
pull from: heartsentwined/ember-script
merge into: github-migration:master
Conversation 0 Commits 1 Files Changed 9 +74 -5
heartsentwined commented 2013-04-22 07:23:06 +00:00 (Migrated from github.com)
Copy Link

As titled. Ref: emberscript

I have come across a project where I am heavily developing in ember.js, and I adopted emberscript for the library.

I'd like to use emberscript in jasmine-headless-webkit too, but it seems that the supported Sprockets engines are hard-coded. I tried adding to it only in userland code, but it ended up being a large hack, cross-referencing and monkey-patching jasmine-headless-webkit itself all over the place.

This PR adds emberscript support by hardcoding it into the library, just like how coffeescript is done. Not sure if I have done it The Right Way though, basically I just copied everything that is coffeescript-related, and made an emberscript version for it.

If it could be refactored to include only the needed extensions on-demand and allow userland injections of new Sprockets engines, then it would be perfect - but I don't know how to do it. As for the added heavyweight for a niche audience, well, IMHO jst templates do not appear that often either. So I'd say the inclusion of emberscript is likewise justifiable simply as a harmless bonus feature like the jst case.

As titled. Ref: [emberscript](http://emberscript.com/) I have come across a project where I am heavily developing in [ember.js](http://emberjs.com/), and I adopted emberscript for the library. I'd like to use emberscript in `jasmine-headless-webkit` too, but it seems that the supported Sprockets engines are hard-coded. I tried adding to it only in userland code, but it ended up being a large hack, cross-referencing and monkey-patching `jasmine-headless-webkit` itself all over the place. This PR adds emberscript support by hardcoding it into the library, just like how coffeescript is done. Not sure if I have done it The Right Way though, basically I just copied everything that is coffeescript-related, and made an emberscript version for it. If it could be refactored to include only the needed extensions on-demand and allow userland injections of new Sprockets engines, then it would be perfect - but I don't know how to do it. As for the added heavyweight for a niche audience, well, IMHO `jst` templates do not appear that often either. So I'd say the inclusion of emberscript is likewise justifiable simply as a harmless bonus feature like the `jst` case.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin heartsentwined/ember-script:heartsentwined/ember-script
git checkout heartsentwined/ember-script
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#179
No description provided.
Delete Branch "heartsentwined/ember-script"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?