github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

getopt is not in scope #175

Open
lcoq wants to merge 1 commits from lcoq/master into master
pull from: lcoq/master
merge into: github-migration:master
Conversation 1 Commits 1 Files Changed 1 +1
lcoq commented 2013-01-14 12:32:29 +00:00 (Migrated from github.com)
Copy Link

This PR fixes issue #170.
I just implemented the fix described in this issue, so it works in some cases, but maybe not for all.

This PR fixes issue #170. I just implemented the fix described in this issue, so it works in some cases, but maybe not for all.
johnbintz commented 2013-01-14 17:18:00 +00:00 (Migrated from github.com)
Copy Link

I'm wary about accepting a patch that may work for some and not for others, especially on a project I really have no interest in working on anymore. I've been looking for a new maintainer for quite a while now and no one has stepped up, and the last thing I have time to do right now is deal with the fallout from a code change.

I would suggest that you keep this in your own fork, and eventually start looking at using one of the other JavaScript unit test runners for your project, like testem or testacular, or something that uses PhantomJS. They have a great many advantages over what is here, and they're also actively maintained. Or, if you want to continue this particular project along, I'll be more than happy to transfer whatever I need to on Rubygems.org over to you so you can publish new gems for it.

I'm wary about accepting a patch that may work for some and not for others, especially on a project I really have no interest in working on anymore. I've been looking for a new maintainer for quite a while now and no one has stepped up, and the last thing I have time to do right now is deal with the fallout from a code change. I would suggest that you keep this in your own fork, and eventually start looking at using one of the other JavaScript unit test runners for your project, like testem or testacular, or something that uses PhantomJS. They have a great many advantages over what is here, and they're also actively maintained. Or, if you want to continue this particular project along, I'll be more than happy to transfer whatever I need to on Rubygems.org over to you so you can publish new gems for it.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin lcoq/master:lcoq/master
git checkout lcoq/master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#175
No description provided.
Delete Branch "lcoq/master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?