github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

Refactored and simplified Sprockets asset caching #153

Open
marcusmateus wants to merge 5 commits from marcusmateus/simplify_sprockets_asset_caching into master
pull from: marcusmateus/simplify_sprockets_asset_caching
merge into: github-migration:master
Conversation 1 Commits 5 Files Changed 15 +57 -279
marcusmateus commented 2012-06-13 03:28:27 +00:00 (Migrated from github.com)
Copy Link
  • Done primarily so postprocessors would work properly (i.e. sprockets-commonjs) when used with my other pull request (#152)
  • Potentially eliminates need for all the JHW specific template engines, except NilTemplate

Note: All the features still pass and the only two spec failures were there prior to my changes. If I have a chance I will dig into fixing them as well later.

- Done primarily so postprocessors would work properly (i.e. sprockets-commonjs) when used with my other pull request (#152) - Potentially eliminates need for all the JHW specific template engines, except NilTemplate Note: All the features still pass and the only two spec failures were there prior to my changes. If I have a chance I will dig into fixing them as well later.
marcusmateus commented 2012-06-13 04:13:29 +00:00 (Migrated from github.com)
Copy Link

I went ahead and removed the JHW specific template engines and their specs. All the features still pass and specs are in the same state.

I did just notice, however, that with my current approach coffeescript caching can not be turned off anymore so that the JS was inlined. I'm not really sure that was all that useful, but it could be added back in... and not just for coffeescript like before. Let me know if you would like to see it back in.

Also, forgot to say thanks for all your hard work on JHW... much appreciated.

I went ahead and removed the JHW specific template engines and their specs. All the features still pass and specs are in the same state. I did just notice, however, that with my current approach coffeescript caching can not be turned off anymore so that the JS was inlined. I'm not really sure that was all that useful, but it could be added back in... and not just for coffeescript like before. Let me know if you would like to see it back in. Also, forgot to say thanks for all your hard work on JHW... much appreciated.
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin marcusmateus/simplify_sprockets_asset_caching:marcusmateus/simplify_sprockets_asset_caching
git checkout marcusmateus/simplify_sprockets_asset_caching
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#153
No description provided.
Delete Branch "marcusmateus/simplify_sprockets_asset_caching"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?