github-migration/cocoon
1
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

_updateFields js should start with first list item position of 1, not 0 #1

Open
aepstein wants to merge 16 commits from aepstein/patch-1 into master
pull from: aepstein/patch-1
merge into: github-migration:master
Conversation 1 Commits 16 Files Changed 11 +321 -4
aepstein commented 2012-12-08 23:20:03 +00:00 (Migrated from github.com)
Copy Link

The logic for inserting new members of the list assumes the first member will have position 1. For consistency with this behavior, _updateFields should also start at 1. The indices generated by jQuery sortable start at 0, so we have to shift them up by 1.

The logic for inserting new members of the list assumes the first member will have position 1. For consistency with this behavior, _updateFields should also start at 1. The indices generated by jQuery sortable start at 0, so we have to shift them up by 1.
johnbintz commented 2012-12-09 19:41:15 +00:00 (Migrated from github.com)
Copy Link

Can you submit a pull request against the formtastic_input branch instead? Thanks!

Can you submit a pull request against the `formtastic_input` branch instead? Thanks!
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin aepstein/patch-1:aepstein/patch-1
git checkout aepstein/patch-1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/cocoon#1
No description provided.
Delete Branch "aepstein/patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?