github-migration/whenever
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixing issue with prepare method. The issue was that [stripped_contents.length..-1] was not capturing the trailing contents as expected. Instead it was grabbing the last 2 characters of my identifier block and then tacking those 2 characters back on to the end. In short, .length and the range operator are not behaving consistently on the input.

Browse Source
This commit is contained in:
Jeremy Lingmann 2011-03-10 21:49:38 -08:00
parent 1f11510d87
commit 7dd0a046ae
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/whenever/command_line.rb
View File

@ -108,11 +108,15 @@ module Whenever
end end
def prepare(contents) def prepare(contents)
# Some cron implementations require all non-comment lines to be newline-terminated. # Strip n lines from the top of the file as specified by the :cut option.
# Preserve any whitespace at the end of contents. (issue #95) # Use split with a -1 limit option to ensure the join is able to rebuild
stripped_contents = contents.strip # the file with all of the original seperators in-tact.
tail = contents[stripped_contents.length..-1] stripped_contents = contents.split($/,-1)[@options[:cut]..-1].join($/)
stripped_contents.split("\n")[@options[:cut]..-1].join("\n") + tail
# Some cron implementations require all non-comment lines to be newline-
# terminated. (issue #95) Strip all newlines and replace with the default
# platform record seperator ($/)
stripped_contents.gsub!(/\s+$/, $/)
end end
def comment_base def comment_base