ensure query strings are built correctly for mechanize

potential fix for invalid query string construction
Bumping version to prerelease until next release
2010-06-01 14:29:57 -04:00 · 2010-06-01 14:10:39 -04:00 · 2010-04-26 22:15:41 -04:00 · 2010-04-26 22:10:16 -04:00
5 changed files with 27 additions and 7 deletions
--- a/History.txt
+++ b/History.txt
@ -1,4 +1,4 @@
-== 0.7.1
+== 0.7.1 / 2010-04-26

 * Minor enhancements

--- a/lib/webrat.rb
+++ b/lib/webrat.rb
@ -2,7 +2,7 @@ require "rack"
 require "nokogiri"

 module Webrat
-  VERSION = "0.7.1.pre"
+  VERSION = "0.7.2.pre"

  autoload :MechanizeAdapter, "webrat/adapters/mechanize"
  autoload :MerbAdapter, "webrat/adapters/merb"
--- a/lib/webrat/core/elements/form.rb
+++ b/lib/webrat/core/elements/form.rb
@ -110,7 +110,7 @@ module Webrat
      when :rack, :sinatra
        Rack::Utils.parse_nested_query(query_string)
      else
-        query_string.split('&').map {|query| { query.split('=').first => query.split('=').last }}
+        Hash[query_string.split('&').map {|query| [ query.split('=').first, query.split('=').last ]}]
      end
    end

--- a/spec/private/core/form_spec.rb
+++ b/spec/private/core/form_spec.rb
@ -48,4 +48,22 @@ describe "Multiple nested params" do
    webrat_session.should_receive(:post).with("/family", params)
    click_button
  end
+
+  it "should correctly construct a query string" do
+    Webrat.configuration.mode = :mechanize
+
+    with_html <<-HTML
+      <html>
+        <form method="get" action="/search">
+          <input type="text" name="query" value="my-query" />
+          <input type="submit" />
+        </form>
+      </html>
+    HTML
+
+    params = { "query" => "my-query" }
+
+    webrat_session.should_receive(:get).with("/search", params)
+    click_button
+  end
 end
--- a/webrat.gemspec
+++ b/webrat.gemspec
@ -2,11 +2,11 @@

 Gem::Specification.new do |s|
  s.name = %q{webrat}
-  s.version = "0.7.1.pre"
+  s.version = "0.7.2.pre"

  s.required_rubygems_version = Gem::Requirement.new("> 1.3.1") if s.respond_to? :required_rubygems_version=
  s.authors = ["Bryan Helmkamp"]
-  s.date = %q{2010-01-17}
+  s.date = %q{2010-04-26}
  s.description = %q{Webrat lets you quickly write expressive and robust acceptance tests
 for a Ruby web application. It supports simulating a browser inside
 a Ruby process to avoid the performance hit and browser dependency of
@ -72,7 +72,7 @@ Most Ruby web frameworks and testing frameworks are supported.}
    "lib/webrat/core_extensions/deprecate.rb",
    "lib/webrat/core_extensions/detect_mapped.rb",
    "lib/webrat/core_extensions/meta_class.rb",
-    "lib/webrat/core_extensions/nil_to_param.rb",
+    "lib/webrat/core_extensions/nil_to_query_string.rb",
    "lib/webrat/core_extensions/tcp_socket.rb",
    "lib/webrat/integrations/merb.rb",
    "lib/webrat/integrations/rails.rb",
@ -195,6 +195,7 @@ Most Ruby web frameworks and testing frameworks are supported.}
    "spec/integration/sinatra/test/test_helper.rb",
    "spec/private/core/configuration_spec.rb",
    "spec/private/core/field_spec.rb",
+    "spec/private/core/form_spec.rb",
    "spec/private/core/link_spec.rb",
    "spec/private/core/session_spec.rb",
    "spec/private/mechanize/mechanize_adapter_spec.rb",
@ -238,7 +239,7 @@ Most Ruby web frameworks and testing frameworks are supported.}
  s.homepage = %q{http://github.com/brynary/webrat}
  s.require_paths = ["lib"]
  s.rubyforge_project = %q{webrat}
-  s.rubygems_version = %q{1.3.5}
+  s.rubygems_version = %q{1.3.6}
  s.summary = %q{Ruby Acceptance Testing for Web applications}
  s.test_files = [
    "spec/fakes/test_adapter.rb",
@ -293,6 +294,7 @@ Most Ruby web frameworks and testing frameworks are supported.}
    "spec/integration/sinatra/test/test_helper.rb",
    "spec/private/core/configuration_spec.rb",
    "spec/private/core/field_spec.rb",
+    "spec/private/core/form_spec.rb",
    "spec/private/core/link_spec.rb",
    "spec/private/core/session_spec.rb",
    "spec/private/mechanize/mechanize_adapter_spec.rb",
Author	SHA1	Message	Date
John Bintz	5e4ffeae9f	ensure query strings are built correctly for mechanize	2010-06-01 14:29:57 -04:00
John Bintz	0856d8d405	potential fix for invalid query string construction	2010-06-01 14:10:39 -04:00
Bryan Helmkamp	8f637e6785	Bumping version to prerelease until next release	2010-04-26 22:15:41 -04:00
Bryan Helmkamp	312c175384	Releasing v0.7.1	2010-04-26 22:10:16 -04:00