github-migration/webrat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
750 Commits 7 Branches 18 Tags 31 MiB
4e07f5b654
Commit Graph

298 Commits

Author SHA1 Message Date
Simon Rozet
4e07f5b654 Fix following of absolute redirect URL in Sinatra 
What's going on when the app redirects to an absolute URL?

* Sinatra relies on Rack::MockSession which sets SERVER_NAME to
  "example.org" [1] on request it makes. However, Webrat expects
  it to be "www.example.com"

* In MyClassyApp, the redirect URL is made out of Rack::Request#url [2]
  which uses  SERVER_NAME, which is set to "example.org" by Rack::MockSession.
  As a result, Webrat see it as an external redirect and don't follow it.

NOTE:

* SERVER_NAME is stricly equivalent to HTTP_HOST [3]
* This could have been fixed in Webrat::Session too. I'am not sure
  that it won't affect other frameworks so I left it intact.

      def request_page(url, http_method, data) #:nodoc:
         h = headers
         h['HTTP_REFERER'] = @current_url if @current_url
  +      h['HTTP_HOST']    = 'www.example.com'

[1] 5c00dd698e/lib/rack/mock.rb (L79)
[2] 5c00dd698e/lib/rack/request.rb (L201)
[3] 5c00dd698e/lib/rack/request.rb (L72)
 2009-02-28 03:30:26 +01:00
Simon Rozet
7d7c32256d Support for "modular" Sinatra app style 
Since Sinatra 0.9, apps can be ancapsulated in a class ("modular" style)
or be on the top level, just like before ("classic" style)

* http://wiki.github.com/brynary/webrat/sinatra
* http://www.sinatrarb.com/extensions.html
 2009-02-28 03:30:25 +01:00
Bryan Helmkamp
4115c99c9b Merge branch 'master' into atmos 2009-02-27 20:41:05 -05:00
Bryan Helmkamp
29c40bd73c Pulling attribute conditions up from have_selector to have_xpath 2009-02-23 20:47:02 -05:00
Bryan Helmkamp
2296cadb93 Pulling features up from have_tag into have_selector 2009-02-23 20:11:25 -05:00
Corey Donohoe
92565d3bc4 use application_environment in merb also 2009-02-18 12:16:19 -07:00
Bryan Helmkamp
b4687c29d5 Break out specs for matchers into separate files 2009-02-15 19:47:12 -05:00
Bryan Helmkamp
17a8bc7b66 Adding :count option to have_tag 2009-02-15 19:41:44 -05:00
Bryan Helmkamp
932fdab884 Get quoting working for content 2009-02-15 19:32:25 -05:00
Bryan Helmkamp
7ba620f38b Whitespace 2009-02-15 18:57:53 -05:00
Corey Donohoe
4fb9406154 remove commented line that serves no purpose 2009-02-15 15:54:04 -07:00
Corey Donohoe
63337d4476 it helps if i make sure the spec suite still passes :\ 2009-02-15 14:41:54 -07:00
Corey Donohoe
69dfa5022a Webrat.configuration.application_type => Webrat.configuration.application_framework 2009-02-15 14:40:17 -07:00
Corey Donohoe
7692930769 clean up constant definitions for rails and fix merb port fubar on selenium appserver stop 2009-02-15 14:37:38 -07:00
Corey Donohoe
9066d2a9cd add specs for starting and stopping appservers, covers rails, sinatra and merb 2009-02-13 20:26:44 -07:00
Peter Jaros
24eab77ecd Accept do/end blocks in matchers. [#157 state:resolved] 2009-02-09 00:31:17 -05:00
Bryan Helmkamp
7fe667da73 Removing HashWithIndifferentAccess 
Doesn't seem to be required, according to our integraton specs
 2009-02-09 00:13:41 -05:00
Bryan Helmkamp
7fc6a79bee Merge commit 'teejayvanslyke/master' into lh_159 2009-02-08 21:03:40 -05:00
Bryan Helmkamp
e97f7fafc5 Add a spec for two checkboxes with the same name (array style) 2009-02-08 20:58:43 -05:00
Bryan Helmkamp
4769a5f90b Detect infinite redirects and raise a Webrat::InfiniteRedirectError (Daniel Lucraft) 2009-02-08 20:54:00 -05:00
T.J. VanSlyke
ea8e1910d1 Added single-quotes around --chdir argument to mongrel_rails call, as 
webrat bombs with a file not found error if RAILS_ROOT contains a space.
 2009-01-30 11:37:43 -08:00
Bryan Helmkamp
7f9df54838 Merge commit 'lenalena/master' into lh_139 2009-01-27 19:13:53 -05:00
Bryan Helmkamp
238bfb469e Use redgreen when running rails integraton tests if available 2009-01-25 19:48:02 -05:00
Mike Gaffney
3d5dd1343c turning off have_tag test for now until we figure out whether we want it or not. Making integration not run the selenium tests for now. Need a eventually framework for test::unit 2009-01-25 18:30:03 -06:00
Amos King
0a021059d6 Added to rails test for have_tag 2009-01-23 21:13:52 -06:00
Amos King
0b8e378fb2 change to use rails label tag for test. 2009-01-23 20:56:16 -06:00
Amos King
8c0facc5af cleanup and tests closes LH #82 2009-01-23 16:05:33 -06:00
Amos King
813adcc238 Remove the rails selenium test directory and change rake tasks for selenium and rails modes to run the same tests. The end goal should be that the same tests run in both Seleium and Webrat. 2009-01-23 15:37:26 -06:00
Amos King
da59584cdf add the ability for selenium mode to create pids dirs 2009-01-23 15:34:51 -06:00
Amos King
2c9b546a83 Merge branch 'lh_120_tests_with_selenium' of git@github.com:gaffo/webrat into lh_82 
Conflicts:
	spec/integration/rails/test/integration/webrat_test.rb
 2009-01-23 15:11:16 -06:00
Zach Dennis
0272e81847 Fixed issue where webrat was only using relative paths when making requests for Rails apps. This borked Rails apps that use subdomains [John Hwang/Zach Dennis] 2009-01-20 21:48:48 -05:00
Josh Knowles
7a59353c78 Unfortunately this commit breaks any Rails specs which pass anchor tags. I like the concept, but I'd prefer to work on this post 0.4.1 once I have a bit more time to work out the failures in our referance app. 
This reverts commit 4fc2b7eb7e.
 2009-01-20 20:08:57 -05:00
Adam Greene
4fc2b7eb7e removing the normalization of url's for the rails session. stipping them of host, port, and anchors is not really needed, especially since josh's redirect change to stop when going to a different host. See comments here: http://webrat.lighthouseapp.com/projects/10503-webrat/tickets/132 2009-01-20 19:30:28 -05:00
Adam Greene
4e3cf59920 adding a helper method to make it easier to see where the user was redirected_to 2009-01-20 19:30:22 -05:00
Adam Greene
ce36e5890f lets follow redirects that are on the same domain but a different subdomain... 2009-01-20 19:30:16 -05:00
Bryan Helmkamp
d60f524df1 Merge commit '1bfe7634f8bb93472f4f53715d43916a8ff1569f' 2009-01-20 00:26:36 -05:00
ichverstehe
1bfe7634f8 sinatra 0.9 support 2009-01-19 23:51:01 +01:00
Kyle Hargraves
6529a016d1 Labels should only search for fields within the current scope 2009-01-19 13:45:36 -06:00
Bryan Helmkamp
14d114ce1d Ensure the previous pages params aren't passed through redirect 2009-01-19 13:56:22 -05:00
Bryan Helmkamp
b8b4a614c4 Use reload instead of deprecated reloads in spec 2009-01-19 13:40:58 -05:00
Kyle Hargraves
2b38b78724 field_labeled() should disregard labels without matching fields 2009-01-18 15:57:08 -06:00
Bryan Helmkamp
f92f9bead8 Parse content as HTML (unless the Content-Type is XML) 2009-01-18 16:34:42 -05:00
Bryan Helmkamp
00d0d7b438 Temporary shim to support Merb's require statement for Webrat 2009-01-18 16:20:58 -05:00
Bryan Helmkamp
fdb94f399c Allow multiple configuration blocks without dropping previous configuration. 
If you really want to start with a default configuration use:

  Webrat.configure(Webrat::Configuration.new) do |config|
    ...
  end
 2009-01-18 16:15:56 -05:00
Bryan Helmkamp
6676ae2da9 Adding integration test for field_labeled 2009-01-17 17:13:20 -05:00
Bryan Helmkamp
9be3f772bf Whitespace 2009-01-17 17:03:31 -05:00
Bryan Helmkamp
45c5a6a34d Remove a couple pending specs 2009-01-17 17:02:05 -05:00
Zach Dennis
cdf9908f9e Fixed bug where Scope was creating a new DOM rather than re-using the existing DOM. [#105 state:resolved] 2009-01-17 16:59:12 -05:00
Bryan Helmkamp
9133fdc0e2 Need test/unit to test assert functionality 2009-01-17 16:34:00 -05:00
Bryan Helmkamp
55bc6b8e00 Merge commit 'gaffo/lh_123' into lh_123 
Conflicts:
	History.txt
 2009-01-17 16:27:39 -05:00