Refactoring locators

lib/webrat/core/locators.rb

@@ -2,7 +2,7 @@ require "webrat/core_extensions/detect_mapped"
 
 module Webrat
   module Locators
-
+    
     def field_by_xpath(xpath)
       field_by_element(Webrat::XML.xpath_at(dom, xpath))
     end

lib/webrat/core/locators/area_locator.rb

@@ -1,9 +1,6 @@
-class AreaLocator
+require "webrat/core/locators/locator"
-  
+
-  def initialize(scope, value)
+class AreaLocator < Locator
-    @scope = scope
-    @value = value
-  end
   
   def locate
     @scope.area_by_element(area_element)

lib/webrat/core/locators/button_locator.rb

@@ -1,9 +1,6 @@
-class ButtonLocator
+require "webrat/core/locators/locator"
-  
+
-  def initialize(scope, value)
+class ButtonLocator < Locator
-    @scope = scope
-    @value = value
-  end
   
   def locate
     @scope.field_by_element(button_element)

lib/webrat/core/locators/field_by_id_locator.rb

@@ -1,9 +1,6 @@
-class FieldByIdLocator
+require "webrat/core/locators/locator"
-  
+
-  def initialize(scope, value)
+class FieldByIdLocator < Locator
-    @scope = scope
-    @value = value
-  end
   
   def locate
     @scope.field_by_element(field_element)

lib/webrat/core/locators/link_locator.rb

@@ -1,24 +1,20 @@
-class LinkLocator
+require "webrat/core/locators/locator"
-  
+
-  def initialize(scope, value)
+class LinkLocator < Locator
-    @scope = scope
-    @value = value
-  end
   
   def locate
-    # TODO - Convert to using elements
+    @scope.link_by_element(link_element)
-    
+  end
-    matching_links = link_elements.select do |link_element|
+  
+  def link_element
+    matching_links.min { |a, b| Webrat::XML.inner_text(a).length <=> Webrat::XML.inner_text(b).length }
+  end
+  
+  def matching_links
+    @matching_links ||= link_elements.select do |link_element|
       matches_text?(link_element) ||
       matches_id?(link_element)
     end
-
-    if matching_links.any?
-      link_element = matching_links.min { |a, b| Webrat::XML.inner_text(a).length <=> Webrat::XML.inner_text(b).length }
-      @scope.link_by_element(link_element)
-    else
-      nil
-    end
   end
   
   def matches_text?(link)

lib/webrat/core/locators/locator.rb

@@ -0,0 +1,8 @@
+class Locator
+  
+  def initialize(scope, value)
+    @scope = scope
+    @value = value
+  end
+  
+end