Use Launchy to handle opening pages in the browser with cross-platform compatibility

History.txt

@@ -8,6 +8,7 @@
 
 * Minor enhancements
 
+  * Use Launchy to handle opening pages in the browser with cross-platform compatibility (Bryan Helmkamp)
   * Added support for field_labeled_locators ending in non word characters
     lh 148 (Zach Dennis)
   * Filled in tests on click link lh 195 (diabolo)

lib/webrat/core/save_and_open_page.rb

@@ -18,12 +18,10 @@ module Webrat
     end
 
     def open_in_browser(path) # :nodoc
-      platform = ruby_platform
+      require "launchy"
-      if platform =~ /cygwin/ || platform =~ /win32/
+      Launchy::Browser.run(path)
-        `rundll32 url.dll,FileProtocolHandler #{path.gsub("/", "\\\\")}`
+    rescue LoadError
-      elsif platform =~ /darwin/
+      warn "Sorry, you need to install launchy to open pages: `gem install launchy`"
-        `open #{path}`
-      end
     end
 
     def rewrite_css_and_image_references(response_html) # :nodoc:

spec/private/core/session_spec.rb

@@ -21,27 +21,6 @@ describe Webrat::Session do
     session.should respond_to(:current_dom)
   end
 
-  it "should open the page in the browser in MacOSX" do
-    session = Webrat::Session.new
-    session.stub!(:ruby_platform => 'darwin')
-    session.should_receive(:`).with("open path")
-    session.open_in_browser("path")
-  end
-
-  it "should open the page in the browser in cygwin" do
-    session = Webrat::Session.new
-    session.stub!(:ruby_platform => 'i386-cygwin')
-    session.should_receive(:`).with("rundll32 url.dll,FileProtocolHandler path\\to\\file")
-    session.open_in_browser("path/to/file")
-  end
-
-  it "should open the page in the browser in Win32" do
-    session = Webrat::Session.new
-    session.stub!(:ruby_platform => 'win32')
-    session.should_receive(:`).with("rundll32 url.dll,FileProtocolHandler path\\to\\file")
-    session.open_in_browser("path/to/file")
-  end
-
   it "should provide a current_page for backwards compatibility" do
     session = Webrat::Session.new
     current_page = session.current_page

spec/public/save_and_open_spec.rb

@@ -17,7 +17,9 @@ describe "save_and_open_page" do
 
     File.stub!(:exist? => true)
     Time.stub!(:now => 1234)
-    webrat_session.stub!(:open_in_browser)
+
+    require "launchy"
+    Launchy::Browser.stub!(:run)
 
     @file_handle = mock("file handle")
     File.stub!(:open).with(filename, 'w').and_yield(@file_handle)
@@ -48,11 +50,19 @@ describe "save_and_open_page" do
     save_and_open_page
   end
 
-  it "should open the temp file in a browser" do
+  it "should open the temp file in a browser with Launchy" do
-    webrat_session.should_receive(:open_in_browser).with(filename)
+    Launchy::Browser.should_receive(:run)
     save_and_open_page
   end
 
+  it "should fail gracefully if Launchy is not available" do
+    Launchy::Browser.should_receive(:run).and_raise(LoadError)
+
+    lambda do
+      save_and_open_page
+    end.should_not raise_error
+  end
+
   def filename
     File.expand_path("./webrat-#{Time.now}.html")
   end