Deprecating old style methods

This commit is contained in:
Bryan Helmkamp 2008-11-24 23:55:39 -05:00
parent 2c26bc8dab
commit 9b1503508b
4 changed files with 20 additions and 20 deletions

View File

@ -1,5 +1,6 @@
require "webrat/core/form" require "webrat/core/form"
require "webrat/core/locators" require "webrat/core/locators"
require "webrat/core_extensions/deprecate"
module Webrat module Webrat
class NotFoundError < WebratError class NotFoundError < WebratError
@ -44,7 +45,7 @@ module Webrat
field.set(options[:with]) field.set(options[:with])
end end
alias_method :fills_in, :fill_in webrat_deprecate :fills_in, :fill_in
def set_hidden_field(field_locator, options = {}) def set_hidden_field(field_locator, options = {})
field = locate_field(field_locator, HiddenField) field = locate_field(field_locator, HiddenField)
@ -60,7 +61,7 @@ module Webrat
locate_field(field_locator, CheckboxField).check locate_field(field_locator, CheckboxField).check
end end
alias_method :checks, :check webrat_deprecate :checks, :check
# Verifies that an input checkbox exists on the current page and marks it # Verifies that an input checkbox exists on the current page and marks it
# as unchecked, so that the value will not be submitted with the form. # as unchecked, so that the value will not be submitted with the form.
@ -71,7 +72,7 @@ module Webrat
locate_field(field_locator, CheckboxField).uncheck locate_field(field_locator, CheckboxField).uncheck
end end
alias_method :unchecks, :uncheck webrat_deprecate :unchecks, :uncheck
# Verifies that an input radio button exists on the current page and marks it # Verifies that an input radio button exists on the current page and marks it
# as checked, so that the value will be submitted with the form. # as checked, so that the value will be submitted with the form.
@ -82,7 +83,7 @@ module Webrat
locate_field(field_locator, RadioField).choose locate_field(field_locator, RadioField).choose
end end
alias_method :chooses, :choose webrat_deprecate :chooses, :choose
# Verifies that a an option element exists on the current page with the specified # Verifies that a an option element exists on the current page with the specified
# text. You can optionally restrict the search to a specific select list by # text. You can optionally restrict the search to a specific select list by
@ -102,7 +103,7 @@ module Webrat
end end
end end
alias_method :selects, :select webrat_deprecate :selects, :select
DATE_TIME_SUFFIXES = { DATE_TIME_SUFFIXES = {
:year => '1i', :year => '1i',
@ -142,7 +143,7 @@ module Webrat
select date.day, :from => "#{id_prefix}_#{DATE_TIME_SUFFIXES[:day]}" select date.day, :from => "#{id_prefix}_#{DATE_TIME_SUFFIXES[:day]}"
end end
alias_method :selects_date, :select_date webrat_deprecate :selects_date, :select_date
# Verifies that time elements (hour, minute) exist on the current page # Verifies that time elements (hour, minute) exist on the current page
# with the specified values. You can optionally restrict the search to a specific # with the specified values. You can optionally restrict the search to a specific
@ -175,8 +176,7 @@ module Webrat
select time.min.to_s.rjust(2,'0'), :from => "#{id_prefix}_#{DATE_TIME_SUFFIXES[:minute]}" select time.min.to_s.rjust(2,'0'), :from => "#{id_prefix}_#{DATE_TIME_SUFFIXES[:minute]}"
end end
webrat_deprecate :selects_time, :select_time
alias_method :selects_time, :select_time
# Verifies and selects all the date and time elements on the current page. # Verifies and selects all the date and time elements on the current page.
# See #select_time and #select_date for more details and available options. # See #select_time and #select_date for more details and available options.
@ -195,7 +195,7 @@ module Webrat
select_time time, options select_time time, options
end end
alias_method :selects_datetime, :select_datetime webrat_deprecate :selects_datetime, :select_datetime
# Verifies that an input file field exists on the current page and sets # Verifies that an input file field exists on the current page and sets
# its value to the given +file+, so that the file will be uploaded # its value to the given +file+, so that the file will be uploaded
@ -208,13 +208,13 @@ module Webrat
locate_field(field_locator, FileField).set(path, content_type) locate_field(field_locator, FileField).set(path, content_type)
end end
alias_method :attaches_file, :attach_file webrat_deprecate :attaches_file, :attach_file
def click_area(area_name) def click_area(area_name)
find_area(area_name).click find_area(area_name).click
end end
alias_method :clicks_area, :click_area webrat_deprecate :clicks_area, :click_area
# Issues a request for the URL pointed to by a link on the current page, # Issues a request for the URL pointed to by a link on the current page,
# follows any redirects, and verifies the final page load was successful. # follows any redirects, and verifies the final page load was successful.
@ -246,7 +246,7 @@ module Webrat
find_link(text_or_title_or_id).click(options) find_link(text_or_title_or_id).click(options)
end end
alias_method :clicks_link, :click_link webrat_deprecate :clicks_link, :click_link
# Verifies that a submit button exists for the form, then submits the form, follows # Verifies that a submit button exists for the form, then submits the form, follows
# any redirects, and verifies the final page was successful. # any redirects, and verifies the final page was successful.
@ -261,7 +261,7 @@ module Webrat
find_button(value).click find_button(value).click
end end
alias_method :clicks_button, :click_button webrat_deprecate :clicks_button, :click_button
def submit_form(id) def submit_form(id)
form = forms.detect { |f| f.matches_id?(id) } form = forms.detect { |f| f.matches_id?(id) }

View File

@ -139,7 +139,7 @@ module Webrat
request_page(@current_url, @http_method, @data) request_page(@current_url, @http_method, @data)
end end
alias_method :reload, :reloads webrat_deprecate :reload, :reloads
# Works like click_link, but only looks for the link text within a given selector # Works like click_link, but only looks for the link text within a given selector
@ -152,7 +152,7 @@ module Webrat
end end
end end
alias_method :clicks_link_within, :click_link_within webrat_deprecate :clicks_link_within, :click_link_within
def within(selector) def within(selector)
scopes.push(Scope.from_scope(self, current_scope, selector)) scopes.push(Scope.from_scope(self, current_scope, selector))
@ -170,7 +170,7 @@ module Webrat
request_page(url, http_method, data) request_page(url, http_method, data)
end end
alias_method :visits, :visit webrat_deprecate :visits, :visit
def open_in_browser(path) # :nodoc def open_in_browser(path) # :nodoc
platform = ruby_platform platform = ruby_platform

View File

@ -1,5 +1,5 @@
class Module #:nodoc: class Module #:nodoc:
def deprecate(old_method_name, new_method_name) def webrat_deprecate(old_method_name, new_method_name)
define_method old_method_name do |*args| define_method old_method_name do |*args|
warn "#{old_method_name} is deprecated. Use #{new_method_name} instead." warn "#{old_method_name} is deprecated. Use #{new_method_name} instead."
__send__(new_method_name, *args) __send__(new_method_name, *args)

View File

@ -30,7 +30,7 @@ describe "click_link" do
<a href="/page">Link text</a> <a href="/page">Link text</a>
HTML HTML
webrat_session.should_receive(:get).with("/page", {}) webrat_session.should_receive(:get).with("/page", {})
clicks_link "ink tex", :method => :get click_link "ink tex", :method => :get
end end
it "should click delete links" do it "should click delete links" do
@ -71,7 +71,7 @@ describe "click_link" do
<a id="link_text_link" href="/page">Link text</a> <a id="link_text_link" href="/page">Link text</a>
HTML HTML
webrat_session.should_receive(:get).with("/page", {}) webrat_session.should_receive(:get).with("/page", {})
clicks_link "link_text_link" click_link "link_text_link"
end end
it "should click links by id regexp" do it "should click links by id regexp" do
@ -79,7 +79,7 @@ describe "click_link" do
<a id="link_text_link" href="/page">Link text</a> <a id="link_text_link" href="/page">Link text</a>
HTML HTML
webrat_session.should_receive(:get).with("/page", {}) webrat_session.should_receive(:get).with("/page", {})
clicks_link /_text_/ click_link /_text_/
end end
it "should click rails javascript links with authenticity tokens" do it "should click rails javascript links with authenticity tokens" do