Ruby 1.9 compatibility: Avoid calling #to_s on Arrays

[#249 state:resolved]
This commit is contained in:
Jakub Kuźma 2009-05-26 10:41:00 +02:00 committed by Bryan Helmkamp
parent b75ff6221b
commit 8b98540aef
2 changed files with 11 additions and 9 deletions

View File

@ -24,15 +24,16 @@
* Bug fixes * Bug fixes
* Translate CSS and image paths with single quotes in save_and_open_page (Erin Staniland) * Translate CSS and image paths with single quotes in save_and_open_page (Erin Staniland)
* Ruby 1.9 compatibility: Avoid calling #to_s on Arrays (Jakub Kuźma)
== 0.4.4 / 2009-04-06 == 0.4.4 / 2009-04-06
* Major enhancements * Major enhancements
* Make selenium process management code more robust and informative * Make selenium process management code more robust and informative
* Minor enhancements * Minor enhancements
* Add support for Rails javascript post links (Mark Menard) * Add support for Rails javascript post links (Mark Menard)
* Upgrade selenium-client dependency to 1.2.14, and update for new waiting * Upgrade selenium-client dependency to 1.2.14, and update for new waiting
API (Balint Erdi) API (Balint Erdi)
@ -43,7 +44,7 @@
* Don't create a new instance of WWW::Mechanize for each request * Don't create a new instance of WWW::Mechanize for each request
(Mark Menard) (Mark Menard)
* Select fields with duplicate selected options sent an incorrect value (Noah Davis) * Select fields with duplicate selected options sent an incorrect value (Noah Davis)
== 0.4.3 / 2009-03-17 == 0.4.3 / 2009-03-17
* Minor enhancements * Minor enhancements
@ -53,7 +54,7 @@
* Initial Merb and Sinatra compatibility for Selenium mode (Corey Donohoe) * Initial Merb and Sinatra compatibility for Selenium mode (Corey Donohoe)
* When faced with a label with no for attribute, that contains a hidden field * When faced with a label with no for attribute, that contains a hidden field
and another field, as can be the case in Rails 2.3's checkbox view, and another field, as can be the case in Rails 2.3's checkbox view,
webrat now locates the non-hidden field. (Luke Melia) webrat now locates the non-hidden field. (Luke Melia)
* Add application_framework config for Selenium mode to determine how to * Add application_framework config for Selenium mode to determine how to
start and stop the app server (Corey Donohoe) start and stop the app server (Corey Donohoe)
@ -69,7 +70,7 @@
attributes in a hash and :count and :content options. See attributes in a hash and :count and :content options. See
have_selector_spec.rb for more. have_selector_spec.rb for more.
* Add the same functionality mentioned above to have_xpath * Add the same functionality mentioned above to have_xpath
* Minor enhancements * Minor enhancements
* Squeeze extra whitespace out of failures messages from contain * Squeeze extra whitespace out of failures messages from contain
@ -96,7 +97,7 @@
redirected to (Adam Greene) redirected to (Adam Greene)
* Recognize input tags with type button (Lena Herrmann) * Recognize input tags with type button (Lena Herrmann)
* Add uncheck method to Selenium mode (Lee Bankewitz) * Add uncheck method to Selenium mode (Lee Bankewitz)
* Bug fixes * Bug fixes
* Make requests to a Rails app using a full URL instead of a relative path. This change * Make requests to a Rails app using a full URL instead of a relative path. This change
@ -107,7 +108,7 @@
to behave correctly (Noah Davis) to behave correctly (Noah Davis)
* Switch to using selenium.click instead of .check when checking a checkbox * Switch to using selenium.click instead of .check when checking a checkbox
(Noah Davis) (Noah Davis)
* Create tmp/pids directory if directory does not exist. (Amos King and Mike Gaffney) * Create tmp/pids directory if directory does not exist. (Amos King and Mike Gaffney)
* Setup deprecated writers for the selenium_environment= and selenium_port= config * Setup deprecated writers for the selenium_environment= and selenium_port= config
* Ensure the previous pages params aren't passed through redirect (Daniel Lucraft and * Ensure the previous pages params aren't passed through redirect (Daniel Lucraft and
Bryan Helmkamp) Bryan Helmkamp)
@ -183,7 +184,7 @@
* Added save_and_open_screengrab for Selenium mode (Luke Melia) * Added save_and_open_screengrab for Selenium mode (Luke Melia)
* Bug fixes * Bug fixes
* field_labeled should disregard labels without matching fields (Kyle Hargraves) * field_labeled should disregard labels without matching fields (Kyle Hargraves)
* Fixed bug where Scope was creating a new DOM rather than re-using the existing DOM. * Fixed bug where Scope was creating a new DOM rather than re-using the existing DOM.
[#105] (Zach Dennis) [#105] (Zach Dennis)

View File

@ -134,7 +134,8 @@ module Webrat
end end
def escaped_value def escaped_value
CGI.escape(@value.to_s) value = @value.respond_to?(:join) ? @value.join : @value
value ? CGI.escape(value) : ""
end end
def labels def labels