Added check for validate_on_create and validate_on_update, which have both been removed in Rails 3

lib/application_checker.rb

@@ -51,6 +51,24 @@ module Rails
         end
       end
       
+      def check_validation_methods
+        files = []
+        
+        ["validate_on_create", "validate_on_update"].each do |v|
+          lines = grep_for(v, "app/models/")
+          files += extract_filenames(lines) || []
+        end
+        
+        if files
+          alert(
+            "Removed validate_on_* methods",
+            "Validate-on-callback methods (validate_on_create/validate_on_destroy) have been removed",
+            "https://rails.lighthouseapp.com/projects/8994/tickets/3880-validate_on_create-and-validate_on_update-no-longer-seem-to-exist",
+            files
+          )
+        end
+      end
+
       # Check for deprecated router syntax
       def check_routes
         lines = ["map\\.", "ActionController::Routing::Routes", "\\.resources"].map do |v|

test/application_checker_test.rb

@@ -58,6 +58,13 @@ class ApplicationCheckerTest < ActiveSupport::TestCase
     assert @checker.alerts.has_key?("Soon-to-be-deprecated ActiveRecord calls")
   end
   
+  def test_check_validation_methods
+    make_file("app/models", "post.rb", "validate_on_create :comments_valid?")
+    @checker.check_validation_methods
+    
+    assert @checker.alerts.has_key?("Removed validate_on_* methods")
+  end
+
   def test_named_scope_left_over
     make_file("app/models", "post.rb", "named_scope :failure")
     @checker.check_ar_methods