github-migration/rails_upgrade
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

check_old_ajax_helpers correctly prints nothing if no problems were found.

Browse Source
This commit is contained in:
Pat George 2010-06-05 05:25:51 +08:00 committed by Jeremy McAnally
parent f44e5c7edf
commit 865e3f7d2a
2 changed files with 127 additions and 114 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/application_checker.rb
View File

@ -245,7 +245,7 @@ module Rails
files += inner_files unless inner_files.nil? files += inner_files unless inner_files.nil?
end end
if files unless files.empty?
alert( alert(
"Deprecated AJAX helper calls", "Deprecated AJAX helper calls",
"AJAX javascript helpers have been switched to be unobtrusive and use :remote => true instead of having a seperate function to handle remote requests.", "AJAX javascript helpers have been switched to be unobtrusive and use :remote => true instead of having a seperate function to handle remote requests.",

13
test/application_checker_test.rb
View File

@ -190,6 +190,19 @@ class ApplicationCheckerTest < ActiveSupport::TestCase
assert @checker.alerts.has_key?("Deprecated ERb helper calls") assert @checker.alerts.has_key?("Deprecated ERb helper calls")
end end
def test_check_old_ajax_helpers
make_file("app/views/sections", "section.js", "<%= link_to_remote 'section-', :update => 'sections', :url => {:action => :destroy, :controller => 'sections', :id => @section.id } %>")
@checker.check_old_ajax_helpers
assert @checker.alerts.has_key?("Deprecated AJAX helper calls")
end
def test_check_old_ajax_helpers_empty
@checker.check_old_ajax_helpers
assert ! @checker.alerts.has_key?("Deprecated AJAX helper calls")
end
def teardown def teardown
clear_files clear_files