github-migration
/
rack-livereload
1
0
Fork 0
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

Only injects code into the first occurrence of <head> tags #62

Open
nathanhoel wants to merge 1 commits from nathanhoel/master into master
pull from: nathanhoel/master
merge into: github-migration:master
Conversation 1 Commits 1 Files Changed 6 +18 -5
6 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/rack/livereload/body_processor.rb
View File

@ -71,7 +71,7 @@ module Rack
@new_body.each do |line| @new_body.each do |line|
if !@livereload_added && line['<head'] if !@livereload_added && line['<head']
line.gsub!(HEAD_TAG_REGEX) { |match| %{#{match}#{template.result(binding)}} } line.sub!(HEAD_TAG_REGEX) { |match| %{#{match}#{template.result(binding)}} }
@livereload_added = true @livereload_added = true
end end
@ -109,4 +109,3 @@ module Rack
end end
end end
end end

1
rack-livereload.gemspec
View File

@ -21,6 +21,7 @@ Gem::Specification.new do |s|
# specify any dependencies here; for example: # specify any dependencies here; for example:
s.add_development_dependency "rspec" s.add_development_dependency "rspec"
s.add_development_dependency "rspec-its"
s.add_development_dependency "cucumber" s.add_development_dependency "cucumber"
s.add_development_dependency "httparty" s.add_development_dependency "httparty"
s.add_development_dependency "sinatra" s.add_development_dependency "sinatra"

10
spec/rack/livereload/body_processor_spec.rb
View File

@ -15,7 +15,7 @@ describe Rack::LiveReload::BodyProcessor do
end end
it 'responds false when no head tag' do it 'responds false when no head tag' do
regex.match("<header></header>").should be_false regex.match("<header></header>").should be_falsey
end end
end end
@ -143,6 +143,14 @@ describe Rack::LiveReload::BodyProcessor do
end end
end end
context 'in document with more than one reference to a head tag' do
let(:page_html) { "<head><head><!-- <head></head> -->" }
it 'should not add the livereload js' do
processed_body.should include == "<!-- <head></head> -->"
end
end
context 'not vendored' do context 'not vendored' do
before do before do
processor.stubs(:use_vendored?).returns(false) processor.stubs(:use_vendored?).returns(false)

2
spec/rack/livereload/processing_skip_analyzer_spec.rb
View File

@ -14,7 +14,7 @@ describe Rack::LiveReload::ProcessingSkipAnalyzer do
describe '#skip_processing?' do describe '#skip_processing?' do
it "should skip processing" do it "should skip processing" do
subject.skip_processing?.should be_true subject.skip_processing?.should be_truthy
end end
end end

2
spec/rack/livereload_spec.rb
View File

@ -20,7 +20,7 @@ describe Rack::LiveReload do
end end
it 'should return the js file' do it 'should return the js file' do
middleware._call(env).should be_true middleware._call(env).should be_truthy
end end
end end
end end

5
spec/spec_helper.rb
View File

@ -1,9 +1,14 @@
require 'mocha/api' require 'mocha/api'
require 'webmock/rspec' require 'webmock/rspec'
require 'rspec/its'
require 'rack-livereload' require 'rack-livereload'
RSpec.configure do |c| RSpec.configure do |c|
c.expect_with :rspec do |config|
config.syntax = :should
end
c.mock_with :mocha c.mock_with :mocha
end end