github-migration/rack-livereload
1
0
Fork 0
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

Don't force iterating chunked (streamed) responses #30

Merged
pdf merged 2 commits from dont_mess_with_chunk_endcoded into master 2013-03-19 13:31:40 +00:00
Conversation 1 Commits 2 Files Changed 2 +18 -1
2 changed files with 18 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 6b93954231 - Show all commits

4
lib/rack/livereload.rb
View File

@ -59,7 +59,9 @@ module Rack
else
status, headers, body = result = @app.call(env)
if (headers['Content-Type'] and headers['Content-Type']['text/event-stream']) or headers['Transfer-Encoding'] == 'chunked'
if (headers['Content-Type'] and headers['Content-Type']['text/event-stream']) or
headers['Transfer-Encoding'] == 'chunked' or
headers['Content-Disposition'] =~ %r{^inline}
return result
end

15
spec/rack/livereload_spec.rb
View File

@ -94,6 +94,21 @@ describe Rack::LiveReload do
end
end
context 'inline disposition' do
let(:body) { [ '<head></head>' ] }
let(:ret) { [ 200, { 'Content-Disposition' => 'inline; filename=my_inlined_file' }, body ] }
before do
app.stubs(:call).with(env).returns(ret)
body.expects(:close).never
body.stubs(:respond_to?).with(:close).returns(true)
end
it 'should pass through' do
middleware.call(env).should == ret
end
end
context 'unknown Content-Type' do
let(:ret) { [ 200, {}, [ 'hey ho' ] ] }