Allow ws:// versus wss:// protocol to be configurable #67

Open
opened 2015-07-23 20:50:30 +00:00 by alexdixon · 3 comments
alexdixon commented 2015-07-23 20:50:30 +00:00 (Migrated from github.com)

The bit I got stuck on trying to get ssl working for our Rails/nginx setup was that the protocol is hard-coded to ws:// in livereload.js. Changing that to wss allowed me to set up the right ssl proxy in nginx to guard.

The bit I got stuck on trying to get ssl working for our Rails/nginx setup was that the protocol is hard-coded to `ws://` in livereload.js. Changing that to `wss` allowed me to set up the right ssl proxy in nginx to guard.
mcmillion commented 2015-10-31 16:56:42 +00:00 (Migrated from github.com)

Ran into this issue trying to get this set up on a new project that's using https. This apparently works in the current livereload project. This project's livereload.js hasn't been updated in 3 years.

Ran into this issue trying to get this set up on a new project that's using https. This apparently works in the current livereload project. This project's livereload.js hasn't been updated in 3 years.
richardonrails commented 2019-01-12 20:05:27 +00:00 (Migrated from github.com)

@mcmillion Where is the "current" livereload project? The README here points to https://github.com/onesupercoder/rack-livereload but it's hardcoded to ws:// there too:

c4262f1194/js/livereload.js (L141)

@mcmillion Where is the "current" livereload project? The README here points to https://github.com/onesupercoder/rack-livereload but it's hardcoded to `ws://` there too: https://github.com/onesupercoder/rack-livereload/blob/c4262f119428870bda5f65f379252c8216499df6/js/livereload.js#L141
richardonrails commented 2019-01-12 20:21:24 +00:00 (Migrated from github.com)
Also related: https://github.com/guard/guard-livereload/issues/143
Sign in to join this conversation.
No Label
No Milestone
No project
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/rack-livereload#67
No description provided.