github-migration/rack-livereload
1
0
Fork 0
Code Issues 11 Pull Requests 4 Packages Projects Releases Wiki Activity

Handle Rails apps running on relative root #27

Merged
adamlogic merged 1 commits from master into master 2013-04-02 15:22:50 +00:00
Conversation 5 Commits 1 Files Changed 3 +14 -3
adamlogic commented 2013-03-08 20:30:32 +00:00 (Migrated from github.com)
Copy Link

rack-livereload was assuming that the rack app is running on the domain root. This isn't always the case, so this commit handles Rails apps running on a relative root. It's specific to Rails, so I'm not sure if it's something you're interested in for rack-livereload.

rack-livereload was assuming that the rack app is running on the domain root. This isn't always the case, so this commit handles Rails apps running on a relative root. It's specific to Rails, so I'm not sure if it's something you're interested in for rack-livereload.
johnbintz commented 2013-03-09 02:08:39 +00:00 (Migrated from github.com)
Copy Link

That works for me. Can you add a test for this before I merge it?

That works for me. Can you add a test for this before I merge it?
adamlogic commented 2013-04-01 21:01:30 +00:00 (Migrated from github.com)
Copy Link

@johnbintz Sorry it took me a while to get to this. Spec has been added.

@johnbintz Sorry it took me a while to get to this. Spec has been added.
johnbintz commented 2013-04-02 14:06:21 +00:00 (Migrated from github.com)
Copy Link

You should merge in the latest HEAD, it has a change that is causing your tests to break.

You should merge in the latest HEAD, it has a change that is causing your tests to break.
adamlogic commented 2013-04-02 14:14:29 +00:00 (Migrated from github.com)
Copy Link

Should be ready to merge now.

Should be ready to merge now.
johnbintz commented 2013-04-02 15:23:05 +00:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/rack-livereload#27
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?