Rack::Lock undefined for threadsafe Rails apps #16

Merged

teamon merged 1 commits from patch-1 into master 2012-11-01 12:50:43 +00:00

Conversation 3 Commits 1 Files Changed 1 +1 -1

teamon commented 2012-11-01 12:48:24 +00:00 (Migrated from github.com)

Copy Link

When using config.threadsafe! there is no Rack::Lock middleware, so

config.middleware.insert_before(Rack::Lock, Rack::LiveReload)

will not work.

I'd suggest using

config.middleware.insert_after(ActionDispatch::Static, Rack::LiveReload)

instead - works for both cases.

When using `config.threadsafe!` there is no Rack::Lock middleware, so ``` ruby config.middleware.insert_before(Rack::Lock, Rack::LiveReload) ``` will not work. I'd suggest using ``` ruby config.middleware.insert_after(ActionDispatch::Static, Rack::LiveReload) ``` instead - works for both cases.

johnbintz commented 2012-11-01 12:50:40 +00:00 (Migrated from github.com)

Copy Link

That works for me, I haven't made the leap yet to threadsafe Rails apps so I never ran into it myself.

That works for me, I haven't made the leap yet to threadsafe Rails apps so I never ran into it myself.

teamon commented 2012-11-01 12:51:16 +00:00 (Migrated from github.com)

Copy Link

That was quick 👍

That was quick :+1:

johnbintz commented 2012-11-01 14:30:03 +00:00 (Migrated from github.com)

Copy Link

We aim to please. :)

We aim to please. :)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/rack-livereload#16

No description provided.