github-migration/prototype
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix an issue with serializing empty array inputs, fixes #7516, merges [6309] and [6312] from from branch

Browse Source
This commit is contained in:
Thomas Fuchs 2007-03-04 21:54:09 +00:00
parent aa7ba0d4ff
commit ebd3351b20
3 changed files with 26 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
CHANGELOG
View File

@ -1,6 +1,8 @@
*SVN*
* Add optional third parameter "camlized" to Element.setStyle, for optimized performance if style names are known to be camelCased. [Thomas Fuchs]
* Fix an issue with serializing empty array inputs, fixes #7516. [stakadush, Mislav Marohnić]
* Add optional third parameter "camelized" to Element.setStyle, for optimized performance if style names are known to be camelCased. [Thomas Fuchs]
* Fix a bug in the simulated hasAttribute for IE due to getAttributeNode sometimes returning null. [sam]

4
src/form.js
View File

@ -8,8 +8,8 @@ var Form = {
var data = elements.inject({}, function(result, element) {
if (!element.disabled && element.name) {
var key = element.name, value = $(element).getValue();
if (value != undefined) {
if (result[key]) {
if (value != null) {
if (key in result) {
if (result[key].constructor != Array) result[key] = [result[key]];
result[key].push(value);
}

23
test/unit/form.html
View File

@ -66,6 +66,14 @@
</form>
</div>
<form id="form_array">
<input type="text" name="twin" value="" />
<input type="text" name="twin" value="siamese" />
<!-- Rails checkbox hack with hidden input: -->
<input type="checkbox" id="checkbox_hack" name="checky" value="1" />
<input name="checky" type="hidden" value="0" />
</form>
<form id="form_getelements">
<select id="tf_selectOne" name="tf_selectOne"><option></option><option>1</option></select>
<textarea id="tf_textarea" name="tf_textarea"></textarea>
@ -273,8 +281,19 @@
$('input_enabled').enable();
assertEqual('val1=4', Form.serialize('form'));
// Checks that select-related serializations work just fine
assertEqual('vu=1&vm%5B%5D=1&vm%5B%5D=3&nvu=One&nvm%5B%5D=One&nvm%5B%5D=Three&evu=&evm%5B%5D=&evm%5B%5D=Three', Form.serialize('form_selects'));
// Checks that select-related serializations work just fine
assertEqual('vu=1&vm%5B%5D=1&vm%5B%5D=3&nvu=One&nvm%5B%5D=One'+
'&nvm%5B%5D=Three&evu=&evm%5B%5D=&evm%5B%5D=Three',
Form.serialize('form_selects'));
// should not eat empty values for duplicate names
$('checkbox_hack').checked = false;
var data = Form.serialize('form_array', true);
assertEnumEqual(['', 'siamese'], data['twin']);
assertEqual('0', data['checky']);
$('checkbox_hack').checked = true;
assertEnumEqual($w('1 0'), Form.serialize('form_array', true)['checky']);
}},
testFormSerializeWorksWithNonFormElements: function() {with(this) {