github-migration/prototype
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve getClass performance. [#747 state:resolved]

Browse Source
This commit is contained in:
Juriy Zaytsev 2009-04-06 11:08:49 -04:00 committed by Tobie Langel
parent add69978e0
commit 41b034b93b
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG
View File

@ -1,3 +1,5 @@
* Remove expensive (for such low-level method) internal `getClass` in favor of plain string comparison (kangax)
* Fix `PeriodicalExecuter` so that it no longer suppresses exceptions. [#696 state:resolved] (Samuel Lebeau, Yaffle)
* Fix issue related to escaping of selectors for querySelectorAll. [#559 state:resolved] (Jorn Holm)

11
src/lang/object.js
View File

@ -10,10 +10,7 @@
**/
(function() {
function getClass(object) {
return Object.prototype.toString.call(object)
.match(/^\[object\s(.*)\]$/)[1];
}
var _toString = Object.prototype.toString;
/**
* Object.extend(destination, source) -> Object
@ -198,7 +195,7 @@
* Returns `true` if `object` is an array; false otherwise.
**/
function isArray(object) {
return getClass(object) === "Array";
return _toString.call(object) == "[object Array]";
}
@ -230,7 +227,7 @@
* Returns `true` if `object` is of type `string`; `false` otherwise.
**/
function isString(object) {
return getClass(object) === "String";
return _toString.call(object) == "[object String]";
}
/**
@ -240,7 +237,7 @@
* Returns `true` if `object` is of type `number`; `false` otherwise.
**/
function isNumber(object) {
return getClass(object) === "Number";
return _toString.call(object) == "[object Number]";
}
/**