github-migration/prototype
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unused local variables. Fix failing form test.

Browse Source
This commit is contained in:
Juriy Zaytsev 2009-03-22 10:53:08 -04:00
parent fa15f212fa
commit 2c986d8eaf
3 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG
View File

@ -1,3 +1,5 @@
* Remove unused local variables from `Element.extend`. Fix one of the form tests to remove `_extendedByPrototype` by setting it to `undefined` rather than `false` (`_extendedByPrototype` being `false` does not force `Element.extend` to re-extend element). (T.J. Crowder, kangax)
* Make test for `escapeHTML`/`unescapeHTML` more strict. (Chrome 1.x escapes "<" and "&" with `innerHTML`, but not ">") (kangax)
* Remove another sniffing from one of DOM tests. Fixes last IE8 failure. (kangax)

2
src/dom/dom.js
View File

@ -1690,7 +1690,7 @@ Element.extend = (function() {
element.nodeType != 1 || element == window) return element;
var methods = Object.clone(Methods),
tagName = element.tagName.toUpperCase(), property, value;
tagName = element.tagName.toUpperCase();
// extend methods for specific tags
if (ByTag[tagName]) Object.extend(methods, ByTag[tagName]);

4
test/unit/form_test.js
View File

@ -291,8 +291,8 @@ new Test.Unit.Runner({
form = $('bigform');
var input = form['tf_text'], select = form['tf_selectOne'];
input._extendedByPrototype = select._extendedByPrototype = false;
input._extendedByPrototype = select._extendedByPrototype = void 0;
this.assert($(input).anInputMethod);
this.assert(!input.aSelectMethod);
this.assertEqual('input', input.anInputMethod());