github-migration/prototype
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Proper fix (and unit tests) for selector escaping issue.

Browse Source
This commit is contained in:
Andrew Dupont 2009-07-17 12:13:47 +02:00
parent f4570f39d7
commit 059ce21040
3 changed files with 20 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/dom/selector.js
View File

@ -170,7 +170,7 @@ var Selector = Class.create({
if (root !== document) {
var oldId = root.id, id = $(root).identify();
// Escape special characters in the ID.
id = id.replace(/[\.:]/g, "\\$1");
id = id.replace(/([\.:])/g, "\\$1");
e = "#" + id + " " + e;
}

11
test/unit/fixtures/selector.html
View File

@ -53,6 +53,17 @@
</span>
</span>
</div> <!-- #dupContainer -->
<div id="dupContainer.withdot:active">
<span id="dupL1_dotcolon" class="span_foo span_bar">
<span id="dupL2_dotcolon">
<span id="dupL3_dotcolon">
<span id="dupL4_dotcolon">
<span id="dupL5_dotcolon"></span>
</span>
</span>
</span>
</span>
</div> <!-- #dupContainer.withdot:active -->
<div id="grandfather"> grandfather
<div id="father" class="brothers men"> father

8
test/unit/selector_test.js
View File

@ -397,6 +397,14 @@ new Test.Unit.Runner({
this.assertEqual(a, b);
},
testElementDownWithDotAndColon: function() {
var a = $('dupL4_dotcolon');
var b = $('dupContainer.withdot:active').down('#dupL4_dotcolon');
var c = $('dupContainer.withdot:active').select('#dupL4_dotcolon');
this.assertEqual(a, b);
this.assertEnumEqual([a], c);
},
testDescendantSelectorBuggy: function() {
var el = document.createElement('div');