Use retry instead of while loop for rescuing connection failure (quasor)

docs/REPLICA_SETS.md

@@ -38,18 +38,14 @@ every half second and time out after thirty seconds.
 
     # Ensure retry upon failure
     def rescue_connection_failure(max_retries=60)
-        success = false
+      retries = 0
-        retries = 0
+      begin
-        while !success
+        yield
-          begin
+      rescue Mongo::ConnectionFailure => ex
-            yield
+        retries += 1
-            success = true
+        raise ex if retries > max_retries
-          rescue Mongo::ConnectionFailure => ex
+        sleep(0.5)
-            retries += 1
+        retry
-            raise ex if retries >= max_retries
-            sleep(0.5)
-          end
-        end
       end
     end
 

test/replica_sets/rs_test_helper.rb

@@ -12,17 +12,15 @@ class Test::Unit::TestCase
   # Generic code for rescuing connection failures and retrying operations.
   # This could be combined with some timeout functionality.
   def rescue_connection_failure(max_retries=60)
-    success = false
+    retries = 0
-    tries   = 0
+    begin
-    while !success && tries < max_retries
+      yield
-      begin
+    rescue Mongo::ConnectionFailure => ex
-        yield
+      puts "Rescue attempt #{retries}"
-        success = true
+      retries += 1
-      rescue Mongo::ConnectionFailure
+      raise ex if retries > max_retries
-        puts "Rescue attempt #{tries}\n"
+      sleep(1)
-        tries += 1
+      retry
-        sleep(1)
-      end
     end
   end