github-migration/master
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
195 Commits 6 Branches 30 Tags 1 MiB
5f0c815256
Commit Graph

195 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michael Kessler
5f0c815256 Cleaning up all specs. 
I basically went through all specs and applied the following rules:

* Use `describe` for methods and `context` for contexts.
* All class methods starts with `.` and instance methods with `#`.
* Removed all `it should`, because the specs _have to_.
* Applied a consistant naming on all listener specs.
* Make fixture usage more fail save by giving generous sleep times.
* Make all behaviour description non-technical and easy to understand.

The goal of this excercise was to have a documentation that is easy
readable and describes the behaviour and not the implementation.

Try it out by using the RSpec documentation format!
 2011-05-13 11:26:05 +02:00
Michael Kessler
34a77dea1a Use the latest guard-rspec for development. 2011-05-13 11:22:12 +02:00
Michael Kessler
1db2456a45 Avoid result sorting by using =~ for array matching. 2011-05-13 09:01:12 +02:00
Michael Kessler
4e47e3e652 Wait 1 second before continue, so the fixture modifications won't influence the subsequent specs. 
This is merely a guess, because all specs pass fine on the local machine but on Travis CI the next
spec that uses the fixtures fails. This might be a problem related to the rounding of the timestamps
in #file_modified?.
 2011-05-12 20:27:07 +02:00
Michael Kessler
beb9f92409 Don't rely on the (almost random) order of an Array. 2011-05-12 18:16:32 +02:00
Michael Kessler
d3dab8b962 Remove unnecessary File creation. Specs are now passing on 1.8.7. 2011-05-12 17:01:48 +02:00
Michael Kessler
3a87a4305c Merge pull request #61 from netzpirat/modified_files_spec 
Add missing specs for file modification detection (See SHA: 0dcf13d77c
 2011-05-12 07:39:59 -07:00
Michael Kessler
a1606b511f Fix sleep typo 2011-05-12 15:03:55 +02:00
Michael Kessler
d36f4c332f Add missing specs for file modification detection (See SHA: 0dcf13d77c) 2011-05-12 15:01:21 +02:00
Thibaud Guillaume-Gentil
f424854e61 Refactorized notifier enabling/disabling 2011-05-10 21:22:25 +02:00
Thibaud Guillaume-Gentil
0dcf13d77c - Handled quick file (<1s) modification 
- Avoid to catch modified files without content modification (sha1 checksum)
(Specs needed)
 2011-05-09 09:39:11 +02:00
Thibaud Guillaume-Gentil
f7140f2b1c Removed commented stuff 2011-05-09 09:36:09 +02:00
Thibaud Guillaume-Gentil
ec2de278ad Removed bundler dev dep version (Travis is now using 1.1.pre.4) 2011-05-08 22:08:28 +02:00
Thibaud Guillaume-Gentil
aabf0583b3 Merge branch 'master' of github.com:guard/guard 
Conflicts:
	lib/guard.rb
	spec/guard_spec.rb
 2011-05-08 22:01:35 +02:00
Thibaud Guillaume-Gentil
29ad7cd8b1 Updated gem dev deps 2011-05-08 21:56:59 +02:00
Thibaud Guillaume-Gentil
1e5ab84b3a Fixed Guard::Notifier (when growl/libnotify not present) 2011-05-08 21:56:46 +02:00
Rémy Coutable
6d5cb96eef Removed unexpected "`" in README 2011-05-07 15:58:19 -07:00
Rémy Coutable
b7137bbf0c Made the README even more gorgeous! 2011-05-07 19:09:43 +02:00
Rémy Coutable
057549a84d Readme cleanup 2011-05-07 19:00:21 +02:00
Rémy Coutable
df98c4ff4c Merge branch 'master' of github.com:guard/guard 2011-05-07 18:48:13 +02:00
Rémy Coutable
d7b0876178 Merge pull request #60 from stereobooster/master 
Windows support!
 2011-05-07 09:47:18 -07:00
Rémy Coutable
9cfe8d3635 Don't modify a frozen hash. 2011-05-07 18:40:13 +02:00
slavic
29069cdeb7 Update documentation for windows support 2011-05-07 15:18:32 +03:00
slavic
92f81d383a Merge with current guard (commit '5352528530f29d3db523261560ee6920063c85b5') 2011-05-07 15:17:41 +03:00
slavic
5c93116d6f Update documentation for windows support 2011-05-07 13:40:45 +03:00
slavic
fc9c5f4284 Merge windows branch. Tested 1.8.7-p334-i386-mingw32 & 1.9.2-p180-i386-mingw32 2011-05-07 13:18:24 +03:00
Thibaud Guillaume-Gentil
5352528530 Merge branch 'master' of https://github.com/stereobooster/guard into stereobooster-master 
Conflicts:
	lib/guard/interactor.rb
 2011-05-06 23:35:09 +02:00
Thibaud Guillaume-Gentil
2f94f9e22f Fixed notification option 
Only print notification "Install message" once
Added GUARD_NOTIFY=false env variable support
Fixes #28
 2011-05-06 23:19:31 +02:00
Thibaud Guillaume-Gentil
fa44ef31bc Moved stop "\n" 2011-05-06 22:58:18 +02:00
Thibaud Guillaume-Gentil
75c1758b22 Updated Guardfile 2011-05-06 22:57:44 +02:00
Thibaud Guillaume-Gentil
d7394e4262 Bye bye 1.8.6 support. 2011-05-06 22:10:38 +02:00
Thibaud Guillaume-Gentil
5740548a51 Kept support of Rubygems < 1.8.0 (for now!) 2011-05-06 21:51:50 +02:00
Thibaud Guillaume-Gentil
a84e46ab48 Oups! 2011-05-06 21:29:22 +02:00
Thibaud Guillaume-Gentil
296837895a Skipped Guard::Notifier spec if growl/libnotify not installed 2011-05-06 21:27:28 +02:00
Thibaud Guillaume-Gentil
660baf7adc Tried to not require rb-inotify (travis-ci issue) 2011-05-06 21:24:00 +02:00
Thibaud Guillaume-Gentil
2da724f5e9 Fixed Rubygems deprecation messages 2011-05-06 21:23:30 +02:00
Thibaud Guillaume-Gentil
f7e9e42dce Skipped Darwin/Linux listener specs if rb-fsevent/rb-inotify not available 2011-05-06 21:15:33 +02:00
Thibaud Guillaume-Gentil
869ed2fa28 Fixed Interactor spec 2011-05-06 21:14:39 +02:00
Thibaud Guillaume-Gentil
d6d9dd9e75 Merge pull request #58 from nicksieger/interactor-module-methods 
Extract code from signal handlers into methods
 2011-05-06 12:08:45 -07:00
Thibaud Guillaume-Gentil
466f4273f4 Merge pull request #57 from nicksieger/specs-green-on-jruby 
Fix spec on JRuby that was failing due to different execution order
 2011-05-06 12:04:19 -07:00
Nick Sieger
70c15a7c94 Extract code from signal handlers into methods 
This will allow building other mechanisms to interact with Guard, for
example on JRuby, where signal handling tends to be unreliable.
 2011-05-06 12:45:47 -05:00
Nick Sieger
5c1e264c39 Fix spec on JRuby that was failing due to different execution order 2011-05-06 12:09:00 -05:00
Rémy Coutable
815a81dd54 Merge pull request #56 from bltavares/master 
Changed some loops to positive statements
 2011-05-05 23:40:41 -07:00
Bruno Tavares
ed0b086cc5 Removed the unless with multiple conditions. Changed it back to if 2011-05-05 20:52:11 -03:00
Bruno Tavares
cefb872360 Changed some conditions to positive statement 2011-05-05 20:14:58 -03:00
slavic
0f7bca7bbd now all specs work 2011-05-01 21:49:16 +03:00
slavic
94e04ec7e0 add support for Windows using rb-fchange. Specs fail because of k32WaitForMultipleObjects blocks all threads 2011-04-30 13:38:57 +03:00
Rémy Coutable
d12a2368b2 Added links to issues in CHANGELOG 2011-04-30 01:47:11 +02:00
Rémy Coutable
8d3ad21cb1 Added .travis.yml file 2011-04-30 01:40:54 +02:00
Rémy Coutable
de42d0d08a Convert CHANGELOG from RDOC to Markdown and cleaned it! 
Signed-off-by: Rémy Coutable <rymai@rymai.me>
 2011-04-30 01:39:40 +02:00