github-migration/jasmine-spec-extras
1
0
Fork 0
Code Issues 2 Pull Requests Packages Projects Releases Wiki Activity

Add dummy rails engine for Rails 3.1 asset path inclusion #2

Merged
dzello merged 1 commits from master into master 2011-12-17 16:07:58 +00:00
Conversation 3 Commits 1 Files Changed 1 +8
dzello commented 2011-12-17 04:44:59 +00:00 (Migrated from github.com)
Copy Link

In a Rails 3.1 application Rails.application.config.assets.paths will
now include this gem's javascripts automatically.

In a Rails 3.1 application Rails.application.config.assets.paths will now include this gem's javascripts automatically.
dzello commented 2011-12-17 05:36:10 +00:00 (Migrated from github.com)
Copy Link

What do you think? I toyed with the idea of using a defined? check but stuck to your advice on just rescuing the load error. Tried locally with Rails and non-Rails and behaves as expected.

What do you think? I toyed with the idea of using a `defined?` check but stuck to your advice on just rescuing the load error. Tried locally with Rails and non-Rails and behaves as expected.
dzello commented 2011-12-17 05:48:36 +00:00 (Migrated from github.com)
Copy Link

This pull alerted me to the fact that my git and github settings had deviated and my commits weren't getting associated with my github id. I fixed that, then redid the change as a single commit and push+forced it up. Somehow your original comment was lost in the mix, apologies on that.

This pull alerted me to the fact that my git and github settings had deviated and my commits weren't getting associated with my github id. I fixed that, then redid the change as a single commit and push+forced it up. Somehow your original comment was lost in the mix, apologies on that.
johnbintz commented 2011-12-17 16:07:54 +00:00 (Migrated from github.com)
Copy Link

Actually, yeah, it could be done w/ defined? now that I think about it but I'm not going to be picky right now. :) Thanks!

Actually, yeah, it could be done w/ `defined?` now that I think about it but I'm not going to be picky right now. :) Thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-spec-extras#2
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?