github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

Patch to allow running specs containing UTF-8 #47

Merged
samstokes merged 1 commits from master into master 2011-08-03 12:23:03 +00:00
Conversation 1 Commits 1 Files Changed 1 +1
samstokes commented 2011-08-03 03:58:41 +00:00 (Migrated from github.com)
Copy Link

Hi, I added this patch to allow running specs whose source files contain UTF-8-encoded characters. We found these specs would pass when run via a normal browser and the regular Jasmine spec server, but would fail under jasmine-headless-webkit because the headless browser was loading the source files as latin1.

The fix is to set the character encoding of the autogenerated HTML test harness to UTF-8, which causes the headless browser to assume all the loaded source files are also UTF-8. (This is the same approach as taken by the spec server.)

Cheers,

Sam Stokes
Rapportive

Hi, I added this patch to allow running specs whose source files contain UTF-8-encoded characters. We found these specs would pass when run via a normal browser and the regular Jasmine spec server, but would fail under jasmine-headless-webkit because the headless browser was loading the source files as latin1. The fix is to set the character encoding of the autogenerated HTML test harness to UTF-8, which causes the headless browser to assume all the loaded source files are also UTF-8. (This is the same approach as taken by the spec server.) ## Cheers, Sam Stokes Rapportive
johnbintz commented 2011-08-03 12:23:12 +00:00 (Migrated from github.com)
Copy Link

Looks great, thanks!

Looks great, thanks!
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#47
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?