github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

Qt 4.8 fix #177

Merged
jeremy-brenner merged 1 commits from master into master 2013-03-15 17:59:24 +00:00
Conversation 1 Commits 1 Files Changed 1 +4
jeremy-brenner commented 2013-03-15 16:28:00 +00:00 (Migrated from github.com)
Copy Link

Just a compiler directive to include getopt.h when qt version > 4.8. Fixes specrunner compile issues on newer qt versions:

specrunner.cpp: In function ‘int main(int, char*)’:
specrunner.cpp:37:39: error: ‘getopt’ was not declared in this scope
specrunner.cpp:43:20: error: ‘optarg’ was not declared in this scope
specrunner.cpp:48:7: error: ‘optind’ was not declared in this scope
specrunner.cpp:61:16: error: ‘optind’ was not declared in this scope
make: ** [specrunner.o] Error 1

If you could merge it would be superfantastic.

Just a compiler directive to include getopt.h when qt version > 4.8. Fixes specrunner compile issues on newer qt versions: specrunner.cpp: In function ‘int main(int, char*_)’: specrunner.cpp:37:39: error: ‘getopt’ was not declared in this scope specrunner.cpp:43:20: error: ‘optarg’ was not declared in this scope specrunner.cpp:48:7: error: ‘optind’ was not declared in this scope specrunner.cpp:61:16: error: ‘optind’ was not declared in this scope make: *_\* [specrunner.o] Error 1 If you could merge it would be superfantastic.
jeremy-brenner commented 2013-03-15 17:25:59 +00:00 (Migrated from github.com)
Copy Link

P.S. This doesn't break builds on qt 4.7

P.S. This doesn't break builds on qt 4.7
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#177
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?