github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

Add a minimum required rubygems version to the gemspec #116

Closed
jwinter wants to merge 2 commits from required-rubygems-version into master
pull from: required-rubygems-version
merge into: github-migration:master
Conversation 2 Commits 2 Files Changed 2 +2 -4
jwinter commented 2012-02-08 03:12:39 +00:00 (Migrated from github.com)
Copy Link

Adds a minimum rubygems version to check the dependency at installation time instead of runtime. 1.8.0 is the version that adds Gem::Specification#each, so that's what I set the minimum to.

Adds a minimum rubygems version to check the dependency at installation time instead of runtime. 1.8.0 is the version that adds Gem::Specification#each, so that's what I set the minimum to.
johnbintz commented 2012-02-08 13:49:55 +00:00 (Migrated from github.com)
Copy Link

Thanks for the pull! I actually have a need to use the Sprockets gem finding code in other projects, so I took your idea and put it into sprockets-vendor_gems and am having jasmine-headless-webkit use that project to search for vendored files. Hope you don't mind. ;)

Thanks for the pull! I actually have a need to use the Sprockets gem finding code in other projects, so I took your idea and put it into [sprockets-vendor_gems](http://github.com/johnbintz/sprockets-vendor_gems) and am having jasmine-headless-webkit use that project to search for vendored files. Hope you don't mind. ;)
jwinter commented 2012-02-08 18:06:48 +00:00 (Migrated from github.com)
Copy Link

Looks good to me. :)

Looks good to me. :)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#116
No description provided.
Delete Branch "required-rubygems-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?