github-migration/jasmine-headless-webkit
1
0
Fork 0
Code Issues 39 Pull Requests 16 Packages Projects Releases Wiki Activity

JS files are included multiple time #10

New Issue
Closed
opened 2011-06-11 11:57:05 +00:00 by dnagir · 4 comments
dnagir commented 2011-06-11 11:57:05 +00:00 (Migrated from github.com)
Copy Link

When using Jasmin config similar to:

src_files:
  - app/assets/javascripts/must_be_first.js
  - app/assets/javascripts/**/**.js

The must_be_first.js is included twice. It look like there is no check for already included files when wildcards are used.

When using Jasmin config similar to: ``` src_files: - app/assets/javascripts/must_be_first.js - app/assets/javascripts/**/**.js ``` The `must_be_first.js` is included twice. It look like there is no check for already included files when wildcards are used.
johnbintz commented 2011-06-11 13:56:54 +00:00 (Migrated from github.com)
Copy Link

I just pushed c29757ad9f which should fix that issue. Take it for a spin and let me know if it works for you.

I just pushed c29757ad9f82b3602bc8714122ab294498fbd09f which should fix that issue. Take it for a spin and let me know if it works for you.
johnbintz commented 2011-06-11 13:59:41 +00:00 (Migrated from github.com)
Copy Link

Oof, I didn't mean to close it. Stupid lack of coffee. You close it when it's fixed. :)

Oof, I didn't mean to close it. Stupid lack of coffee. You close it when it's fixed. :)
dnagir commented 2011-06-11 17:29:51 +00:00 (Migrated from github.com)
Copy Link

That's fixed. But I am now getting the warning:

NOTE: Gem.available? is deprecated, use Specification::find_by_name. It will be removed on or after 2011-11-01.
Gem.available? called from /home/dima/.rvm/gems/ruby-1.9.2-p180/gems/jasmine-1.0.2.1/lib/jasmine/base.rb:64.

The warning must be related to rubygems/rake that broke the world. But just thought to let you know.

That's fixed. But I am now getting the warning: ``` NOTE: Gem.available? is deprecated, use Specification::find_by_name. It will be removed on or after 2011-11-01. Gem.available? called from /home/dima/.rvm/gems/ruby-1.9.2-p180/gems/jasmine-1.0.2.1/lib/jasmine/base.rb:64. ``` The warning must be related to rubygems/rake that broke the world. But just thought to let you know.
johnbintz commented 2011-06-12 03:24:50 +00:00 (Migrated from github.com)
Copy Link

Looks like an issue with jasmine-gem. There's a pull request for it: https://github.com/pivotal/jasmine-gem/pull/41

Looks like an issue with jasmine-gem. There's a pull request for it: https://github.com/pivotal/jasmine-gem/pull/41
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
doc

   
feature
No Label
bug
doc
feature
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/jasmine-headless-webkit#10
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?