github-migration/guard-rails
1
0
Fork 0
Code Issues 6 Pull Requests 2 Packages Projects Releases Wiki Activity

Ubuntu, linux support #2

Merged
sid137 merged 2 commits from master into master 2011-06-29 13:53:55 +00:00
Conversation 4 Commits 2 Files Changed 1 +12 -13
sid137 commented 2011-06-20 00:45:56 +00:00 (Migrated from github.com)
Copy Link

Hi,

I had some problems getting this to work on linux, so made some changes. It wasn't restarting the server at all.

-Sidney

Hi, I had some problems getting this to work on linux, so made some changes. It wasn't restarting the server at all. -Sidney
johnbintz commented 2011-06-20 00:55:18 +00:00 (Migrated from github.com)
Copy Link

That looks good. Think you can refactor the code in unmanaged_pid a bit more to remove the duplication? There isn't much difference between the two codepaths, so any refactoring would be very nice to have. :)

That looks good. Think you can refactor the code in `unmanaged_pid` a bit more to remove the duplication? There isn't much difference between the two codepaths, so any refactoring would be very nice to have. :)
sid137 commented 2011-06-20 01:24:19 +00:00 (Migrated from github.com)
Copy Link

ok, changed... you might be able to simply use lsof -i :#{port} as well on mac too..

ok, changed... you might be able to simply use lsof -i :#{port} as well on mac too..
johnbintz commented 2011-06-20 01:57:07 +00:00 (Migrated from github.com)
Copy Link

Nope, no dice on lsof -i on Mac OS X. Still need lsof -P...though you might want to tack on the -n option to both lsof calls to get rid of rDNS on both systems and to speed it up (I decided to fire up a local Linux box to check that command. :) ).

Nope, no dice on `lsof -i` on Mac OS X. Still need `lsof -P`...though you might want to tack on the `-n` option to both `lsof` calls to get rid of rDNS on both systems and to speed it up (I decided to fire up a local Linux box to check that command. :) ).
johnbintz commented 2011-06-20 13:17:10 +00:00 (Migrated from github.com)
Copy Link

I was wrong, lsof -i is fine. That's what I get for doing this stuff too late at night. Try the linux-support branch. It incorporates your change and gets it working on both OSes:

https://github.com/johnbintz/guard-rails/tree/linux-support

I was wrong, `lsof -i` is fine. That's what I get for doing this stuff too late at night. Try the `linux-support` branch. It incorporates your change and gets it working on both OSes: https://github.com/johnbintz/guard-rails/tree/linux-support
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/guard-rails#2
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?