start better reporter handling

Gemfile

@@ -4,10 +4,13 @@ source "http://rubygems.org"
 gemspec
 gem 'guard', :git => 'git://github.com/guard/guard.git'
 gem 'rspec'
+gem 'cucumber'
 gem 'mocha'
 gem 'rake', '0.9.2'
 gem 'growl'
 gem 'fakefs', :require => nil
 gem 'jasmine-headless-webkit', :path => '../jasmine-headless-webkit'
 gem 'coffee-script'
+
 gem 'guard-rspec'
+gem 'guard-cucumber'

features/runner.feature

@@ -0,0 +1,11 @@
+Feature: Runner
+  Scenario: Don't specify a reporter
+    Given I am going to call a JHW runner
+      And I am going to get a notification file
+    When I don't specify a reporter
+      And I run the runner
+      Then I should get the following reporters:
+        | name | file |
+        | Console | |
+        | File | notify-file |
+

features/step_definitions/given/i_am_going_to_call_a_runner.rb

@@ -0,0 +1,3 @@
+Given /^I am going to call a JHW runner$/ do
+  pending # express the regexp above with the code you wish you had
+end

features/step_definitions/given/i_am_going_to_get_a_notification.rb

@@ -0,0 +1,3 @@
+Given /^I am going to get a notification file$/ do
+  pending # express the regexp above with the code you wish you had
+end

features/step_definitions/then/i_should_get_reporters.rb

@@ -0,0 +1,5 @@
+Then /^I should get the following reporters:$/ do |table|
+  # table is a Cucumber::Ast::Table
+  pending # express the regexp above with the code you wish you had
+end
+

features/step_definitions/when/i_dont_specify_a_reporter.rb

@@ -0,0 +1,3 @@
+When /^I don't specify a reporter$/ do
+  pending # express the regexp above with the code you wish you had
+end

features/support/env.rb

@@ -0,0 +1,17 @@
+require 'rspec'
+require 'mocha'
+
+World(Mocha::Standalone)
+
+Before do
+  mocha_setup
+end
+
+After do
+  begin
+    mocha_verify
+  ensure
+    mocha_teardown
+  end
+end
+

lib/guard/jasmine-headless-webkit/runner.rb

@@ -4,49 +4,44 @@ require 'jasmine-headless-webkit'
 module Guard
   class JasmineHeadlessWebkit
     class Runner
-      class << self
+      def self.run(paths = [], options = {})
-        def run(paths = [], options = {})
+        file = Tempfile.new('guard-jasmine-headless-webkit')
-          file = Tempfile.new('guard-jasmine-headless-webkit')
+        file.close
-          file.close
 
-          options.merge!(:reporters => [
+        options.merge!(:reporters => process_reporters, :colors => true, :files => paths)
-            [ 'Console' ],
-            [ 'File', file.path ]
-          ], :colors => true, :files => paths)
 
-          Jasmine::Headless::Runner.run(options)
+        Jasmine::Headless::Runner.run(options)
 
-          notify(file.path)
+        notify(file.path)
+      end
+
+      def self.notify(file)
+        if (report = Jasmine::Headless::Report.load(file)).valid?
+          Notifier.notify(message(report.total, report.failed, report.time, report.has_used_console?), :title => 'Jasmine results', :image => image(report.has_used_console?, report.failed))
+          report.failed_files
+        else
+          raise Jasmine::Headless::InvalidReport
         end
+      rescue Jasmine::Headless::InvalidReport => e
+        Notifier.notify('Spec runner interrupted!', :title => 'Jasmine results', :image => :failed)
+        false
+      end
 
-        def notify(file)
+      private
-          if (report = Jasmine::Headless::Report.load(file)).valid?
+      def self.message(total, fails, secs, any_console)
-            Notifier.notify(message(report.total, report.failed, report.time, report.has_used_console?), :title => 'Jasmine results', :image => image(report.has_used_console?, report.failed))
+        total_word = (total.to_i == 1) ? "test" : "tests"
-            report.failed_files
+
+        "#{total} #{total_word}, #{fails} failures, #{secs} secs#{any_console ? ', console.log used' : ''}."
+      end
+
+      def self.image(any_console, fails)
+        if any_console
+          :pending
+        else
+          if fails.to_i == 0
+            :success
           else
-            raise Jasmine::Headless::InvalidReport
+            :failed
-          end
-        rescue Jasmine::Headless::InvalidReport => e
-          Notifier.notify('Spec runner interrupted!', :title => 'Jasmine results', :image => :failed)
-          false
-        end
-
-        private
-        def message(total, fails, secs, any_console)
-          total_word = (total.to_i == 1) ? "test" : "tests"
-
-          "#{total} #{total_word}, #{fails} failures, #{secs} secs#{any_console ? ', console.log used' : ''}."
-        end
-
-        def image(any_console, fails)
-          if any_console
-            :pending
-          else
-            if fails.to_i == 0
-              :success
-            else
-              :failed
-            end
           end
         end
       end

spec/lib/guard/jasmine-headless-webkit/runner_spec.rb

@@ -2,13 +2,23 @@ require 'spec_helper'
 
 describe Guard::JasmineHeadlessWebkit::Runner do
   describe '.run' do
+    let(:reporter) { 'reporter' }
+
+    before do
+      described_class.stubs(:process_reporters).returns([ reporter ])
+    end
+
     it 'should pass along options' do
-      Jasmine::Headless::Runner.expects(:run).with(has_key(:full_run))
+      Jasmine::Headless::Runner.expects(:run).with(all_of(has_key(:full_run), has_entry(:reporters => [ reporter ])))
 
       Guard::JasmineHeadlessWebkit::Runner.run([], :full_run => false)
     end
   end
 
+  describe '.process_reporters' do
+    subject { 
+  end
+
   describe '.notify' do
     include FakeFS::SpecHelpers