preventing recursive loop when used as engine in an app
This commit is contained in:
parent
32f7552a50
commit
8298b2a4bf
@ -40,13 +40,17 @@ class Admin::MenuCell < Cell::Base
|
||||
method_name = "build_list_with_#{name}".to_sym
|
||||
previous_method_name = "build_list_without_#{name}".to_sym
|
||||
|
||||
self.send(:define_method, method_name) do
|
||||
self.send(previous_method_name)
|
||||
block.call(MenuProxy.new(self))
|
||||
end
|
||||
unless self.instance_methods.include?(method_name) # prevents the method to be called twice which will raise a "stack level too deep" exception
|
||||
|
||||
# Note: this might cause "stack level too deep" if called twice for the same name
|
||||
alias_method_chain :build_list, name.to_sym
|
||||
self.send(:define_method, method_name) do
|
||||
self.send(previous_method_name)
|
||||
block.call(MenuProxy.new(self))
|
||||
end
|
||||
|
||||
# Note: this might cause "stack level too deep" if called twice for the same name
|
||||
alias_method_chain :build_list, name.to_sym
|
||||
|
||||
end
|
||||
end
|
||||
|
||||
protected
|
||||
|
@ -1,4 +1,4 @@
|
||||
class Admin::SettingsMenuCell < ::Admin::MenuCell
|
||||
class Admin::SettingsMenuCell < ::Admin::SubMenuCell #::Admin::MenuCell
|
||||
|
||||
protected
|
||||
|
||||
@ -8,10 +8,10 @@ class Admin::SettingsMenuCell < ::Admin::MenuCell
|
||||
add :account, :url => edit_admin_my_account_url
|
||||
end
|
||||
|
||||
def build_item(name, attributes)
|
||||
item = super
|
||||
enhanced_class = "#{'on' if name.to_s == sections(:sub)} #{item[:class]}"
|
||||
item.merge(:class => enhanced_class)
|
||||
end
|
||||
# def build_item(name, attributes)
|
||||
# item = super
|
||||
# enhanced_class = "#{'on' if name.to_s == sections(:sub)} #{item[:class]}"
|
||||
# item.merge(:class => enhanced_class)
|
||||
# end
|
||||
|
||||
end
|
||||
|
11
app/cells/admin/sub_menu_cell.rb
Normal file
11
app/cells/admin/sub_menu_cell.rb
Normal file
@ -0,0 +1,11 @@
|
||||
class Admin::SubMenuCell < ::Admin::MenuCell
|
||||
|
||||
protected
|
||||
|
||||
def build_item(name, attributes)
|
||||
item = super
|
||||
enhanced_class = "#{'on' if name.to_s == sections(:sub)} #{item[:class]}"
|
||||
item.merge(:class => enhanced_class)
|
||||
end
|
||||
|
||||
end
|
Loading…
Reference in New Issue
Block a user