github-migration/comicpress-2.8
1
0
Fork 0
Code Issues 17 Pull Requests Packages Projects Releases Wiki Activity

Move to using filters for incoming file types #48

New Issue
Open
opened 2010-01-21 22:51:10 +00:00 by johnbintz · 0 comments
johnbintz commented 2010-01-21 22:51:10 +00:00 (Migrated from github.com)
Copy Link

display_comic() should exclusively use filters to determine how to display incoming file types, and allow for extension based on said filters, rather than hardcoding the behaviors for specific formats within the function itself.

Metadata for media files (width, height, etc.) can be handled one of three ways. None of these are mutually exclusive, and some are already implemented.

  • Include parsers for filetypes. This potentially adds additional dependencies on the codebase depending on filetype.
  • Pull the metadata from filenames (ex: my-movie-320x240.flv).
  • Pull metadata from post information. This will need to be smart enough to match metadata to the correct file, and flexible & accessible enough so that similar components can be used for different media types (ex: flv and swf both need size information, but swf can also accept additional information such as background color, opacity, etc.)
display_comic() should exclusively use filters to determine how to display incoming file types, and allow for extension based on said filters, rather than hardcoding the behaviors for specific formats within the function itself. Metadata for media files (width, height, etc.) can be handled one of three ways. None of these are mutually exclusive, and some are already implemented. - Include parsers for filetypes. This potentially adds additional dependencies on the codebase depending on filetype. - Pull the metadata from filenames (ex: my-movie-320x240.flv). - Pull metadata from post information. This will need to be smart enough to match metadata to the correct file, and flexible & accessible enough so that similar components can be used for different media types (ex: flv and swf both need size information, but swf can also accept additional information such as background color, opacity, etc.)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/comicpress-2.8#48
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?