github-migration/comicpress-2.8
1
0
Fork 0
Code Issues 17 Pull Requests Packages Projects Releases Wiki Activity

Re-vamping commonly used segments of code. #26

New Issue
Open
opened 2009-12-22 12:29:45 +00:00 by Frumph · 1 comment
Frumph commented 2009-12-22 12:29:45 +00:00 (Migrated from github.com)
Copy Link

I'm thinking I want to revamp code that is used in multiple places as a function that echos an output out and add a filter to each individual position, thoughts?

For example, the Comments link is used in the comicblogpost blogpost and can have a partial as well as it's used in the comments widget, if I set that as a function we can call it from all three and put a filter on it and reduce code usage, could pretty much do that for almost everything.

Would it be better to have a function call or have it straight parse, as in the way of memory and system usage?

I'm thinking I want to revamp code that is used in multiple places as a function that echos an output out and add a filter to each individual position, thoughts? For example, the Comments link is used in the comicblogpost blogpost and can have a partial as well as it's used in the comments widget, if I set that as a function we can call it from all three and put a filter on it and reduce code usage, could pretty much do that for almost everything. Would it be better to have a function call or have it straight parse, as in the way of memory and system usage?
johnbintz commented 2009-12-25 17:11:08 +00:00 (Migrated from github.com)
Copy Link

Filters. Don't worry about performance, just get the code cleaned up. We can worry about performance issues later.

Filters. Don't worry about performance, just get the code cleaned up. We can worry about performance issues later.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/comicpress-2.8#26
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?