display_comic() should use filters to handle special options #18

New Issue

2009-12-02T20:11:33Z

johnbintz commented

2009-12-02 20:11:33 +00:00

(Migrated from github.com)

display_comic() as it is now is too hard-coded. It should be using filters to handle the heavy lifting of alternate display methods:

echo apply_filters('comicpress_display_comic','', $comicpress_options);

With the lower-down filters skipping their processing if the incoming $content (the first parameter) is not empty().

display_comic() as it is now is too hard-coded. It should be using filters to handle the heavy lifting of alternate display methods: echo apply_filters('comicpress_display_comic','', $comicpress_options); With the lower-down filters skipping their processing if the incoming $content (the first parameter) is not empty().

Frumph commented

2010-01-06 14:20:20 +00:00

(Migrated from github.com)

This is done if you can view it, i've got a problem with a filter someplace adding an extra for some reason, not sure what it is if you can look at it.
64ac05ce57

This is done if you can view it, i've got a problem with a filter someplace adding an extra </a> for some reason, not sure what it is if you can look at it. http://github.com/johnbintz/comicpress-2.8/commit/64ac05ce57bd2e81fddda45f9a3ef24e51e79648

Sign in to join this conversation.

No Label

No Milestone

No project

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: github-migration/comicpress-2.8#18