github-migration
/
comicpress-2.8
1
0
Fork 0
Code Issues 17 Pull Requests Packages Projects Releases Wiki Activity

performance enhancements for category parent -> child mapping

This commit is contained in:
John Bintz 2010-01-14 20:54:50 -05:00
parent d8b7e04127
commit 08694eaf85
2 changed files with 52 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
classes/ComicPressDBInterface.inc
View File

@ -106,6 +106,19 @@ class ComicPressDBInterface {
function get_next_post($categories = null, $override_post = null) { return $this->get_adjacent_post($categories, true, $override_post); } function get_next_post($categories = null, $override_post = null) { return $this->get_adjacent_post($categories, true, $override_post); }
// @codeCoverageIgnoreEnd // @codeCoverageIgnoreEnd
}
?> function get_parent_child_category_ids() {
global $wpdb;
$parent_child_categories = array();
$result = $wpdb->get_results("SELECT term_id, parent FROM $wpdb->term_taxonomy", ARRAY_A);
if (!empty($result)) {
foreach ($result as $row) {
$parent_child_categories[$row['term_id']] = $row['parent'];
}
}
return $parent_child_categories;
}
}

44
classes/ComicPressStoryline.inc
View File

@ -247,19 +247,36 @@ class ComicPressStoryline {
return $this->_merge_simple_storyline($simple_storyline); return $this->_merge_simple_storyline($simple_storyline);
} }
// @codeCoverageIgnoreStart
function get_comicpress_dbi() {
return ComicPressDBInterface::get_instance();
}
// @codeCoverageIgnoreEnd
/** /**
* Get a simple structure. * Get a simple structure.
*/ */
function get_category_simple_structure($parent = null) { function get_category_simple_structure($parent = null) {
$structure = array(); $cache_key = $this->generate_cache_key('storyline-structure', $parent);
foreach (get_all_category_ids() as $category_id) { $result = wp_cache_get($cache_key, 'comicpress');
$category = get_category($category_id); if (is_array($result)) {
if (!isset($structure[$category->parent])) { return $result;
$structure[$category->parent] = array();
}
$structure[$category->parent][$category_id] = true;
} }
$structure = array();
$dbi = $this->get_comicpress_dbi();
$result = $dbi->get_parent_child_category_ids();
foreach ($result as $cat_id => $cat_parent) {
if (!isset($structure[$cat_parent])) {
$structure[$cat_parent] = array();
}
$structure[$cat_parent][$cat_id] = true;
}
$structure = $this->_merge_simple_storyline($structure); $structure = $this->_merge_simple_storyline($structure);
if (!empty($parent)) { if (!empty($parent)) {
if (isset($structure[0])) { if (isset($structure[0])) {
foreach ($structure[0] as $key => $children) { foreach ($structure[0] as $key => $children) {
@ -267,9 +284,19 @@ class ComicPressStoryline {
} }
} }
} }
wp_cache_set($cache_key, $structure, 'comicpress');
return $structure; return $structure;
} }
function generate_cache_key($key_name, $param) {
if (!empty($param)) {
$key_name = "${key_name}-${param}";
}
return $key_name;
}
/** /**
* Get a flattened category node list. * Get a flattened category node list.
*/ */
@ -339,6 +366,9 @@ class ComicPressStoryline {
$valid_ids = get_all_category_ids(); $valid_ids = get_all_category_ids();
if (!isset($comicpress->comicpress_options['category_groupings'])) { $comicpress->comicpress_options['category_groupings'] = array(); }
if (!is_array($comicpress->comicpress_options['category_groupings'])) { $comicpress->comicpress_options['category_groupings'] = array(); }
foreach ($comicpress->comicpress_options['category_groupings'] as $group_id => $category_ids) { foreach ($comicpress->comicpress_options['category_groupings'] as $group_id => $category_ids) {
$comicpress->comicpress_options['category_groupings'][$group_id] = array_intersect($category_ids, $valid_ids); $comicpress->comicpress_options['category_groupings'][$group_id] = array_intersect($category_ids, $valid_ids);
if (empty($comicpress->comicpress_options['category_groupings'][$group_id])) { if (empty($comicpress->comicpress_options['category_groupings'][$group_id])) {