From f6dd24f7c53f98e781ef8ea4f59ad49ed42e7472 Mon Sep 17 00:00:00 2001
From: Bryan Helmkamp <bryan@brynary.com>
Date: Fri, 13 Nov 2009 20:57:55 -0500
Subject: [PATCH] Remove bogus integration tests that were passing (sometimes)
 by coincidence

An element of <button type="button" /> is not supposed to submit a form
---
 .../rails/app/views/buttons/show.html.erb         |  1 -
 .../rails/app/views/webrat/buttons.html.erb       |  1 -
 .../rails/test/integration/button_click_test.rb   | 15 ---------------
 3 files changed, 17 deletions(-)

diff --git a/spec/integration/rails/app/views/buttons/show.html.erb b/spec/integration/rails/app/views/buttons/show.html.erb
index 7375623..ca34975 100644
--- a/spec/integration/rails/app/views/buttons/show.html.erb
+++ b/spec/integration/rails/app/views/buttons/show.html.erb
@@ -5,7 +5,6 @@
   <input type="submit" id="input_submit_id" value="input_submit_value" />
   <input type="image" id="input_image_id" value="input_image_value" alt="input_image_alt" src="" />
 
-  <button type="button" id="button_button_id" value="button_button_value">button_button_text</button>
   <button type="submit" id="button_submit_id" value="button_submit_value">button_submit_text</button>
   <button type="image" id="button_image_id" value="button_image_value">button_image_text</button>
 <% end %>
\ No newline at end of file
diff --git a/spec/integration/rails/app/views/webrat/buttons.html.erb b/spec/integration/rails/app/views/webrat/buttons.html.erb
index e127059..b204720 100644
--- a/spec/integration/rails/app/views/webrat/buttons.html.erb
+++ b/spec/integration/rails/app/views/webrat/buttons.html.erb
@@ -5,7 +5,6 @@
   <input type="submit" id="input_submit_id" value="input_submit_value">
   <input type="image" id="input_image_id" value="input_image_value" alt="input_image_alt" src="">
 
-  <button type="button" id="button_button_id" value="button_button_value">button_button_text</button>
   <button type="submit" id="button_submit_id" value="button_submit_value">button_submit_text</button>
   <button type="image" id="button_image_id" value="button_image_value">button_image_text</button>
 <% end %>
\ No newline at end of file
diff --git a/spec/integration/rails/test/integration/button_click_test.rb b/spec/integration/rails/test/integration/button_click_test.rb
index 1bf4627..6129298 100644
--- a/spec/integration/rails/test/integration/button_click_test.rb
+++ b/spec/integration/rails/test/integration/button_click_test.rb
@@ -1,20 +1,6 @@
 require 'test_helper'
 
 class ButtonClickTest < ActionController::IntegrationTest
-  # <button type="button" ...>
-  test "should click button with type button by id" do
-    visit buttons_path
-    click_button "button_button_id"
-  end
-  test "should click button with type button by value" do
-    visit buttons_path
-    click_button "button_button_value"
-  end
-  test "should click button with type button by html" do
-    visit buttons_path
-    click_button "button_button_text"
-  end
-
   # <button type="submit" ...>
   test "should click button with type submit by id" do
     visit buttons_path
@@ -76,5 +62,4 @@ class ButtonClickTest < ActionController::IntegrationTest
     visit buttons_path
     click_button "input_image_alt"
   end
-
 end