From c98aad1e6e03ccd9c2ed8491390a1340a237c793 Mon Sep 17 00:00:00 2001 From: John Bintz Date: Tue, 22 Mar 2011 11:14:57 -0400 Subject: [PATCH] add validity test, a simple one --- lib/avm/image.rb | 4 ++++ spec/avm/image_spec.rb | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/lib/avm/image.rb b/lib/avm/image.rb index 188660f..d06fdfb 100644 --- a/lib/avm/image.rb +++ b/lib/avm/image.rb @@ -161,6 +161,10 @@ module AVM @observations = [] end + def valid? + self.headline && self.credit + end + def create_observation(options) observation = Observation.new(self, options) @observations << observation diff --git a/spec/avm/image_spec.rb b/spec/avm/image_spec.rb index b3cdd09..1246a1d 100644 --- a/spec/avm/image_spec.rb +++ b/spec/avm/image_spec.rb @@ -21,6 +21,8 @@ describe AVM::Image do let(:redshift) { 'Redshift' } let(:light_years) { 'Light years' } + let(:subject_names) { [ 'Name one', 'Name two' ] } + let(:coordinate_frame) { 'ICRS' } let(:equinox) { '100' } let(:reference_value) { [ 100, 50 ] } @@ -119,6 +121,8 @@ describe AVM::Image do its(:related_resources) { should == related_resources } its(:metadata_date) { should == Time.parse(metadata_date) } its(:metadata_version) { should == metadata_version } + + it { should be_valid } end describe '#initialize' do @@ -166,6 +170,12 @@ describe AVM::Image do its(:distance) { should == [ light_years, redshift ] } end + describe 'not valid' do + let(:image) { AVM::Image.new } + + it { should_not be_valid } + end + describe '.from_xml' do let(:image) { AVM::Image.from_xml(File.read(file_path)) } @@ -184,6 +194,8 @@ describe AVM::Image do ].each do |field| its(field) { should be_nil } end + + it { should_not be_valid } end context "image in it" do