From cebf7d673b3a467bb05615b004ad01a519abeb53 Mon Sep 17 00:00:00 2001
From: Juriy Zaytsev <juriy@kangax.local>
Date: Thu, 16 Apr 2009 12:24:20 -0400
Subject: [PATCH] Do not browser sniff when forking `unmark` function in
 selector suite. Instead use a proper test - PROPERTIES_ATTRIBUTES_MAP.

---
 CHANGELOG           |  2 ++
 src/dom/selector.js | 39 +++++++++++++++++++++++++++------------
 2 files changed, 29 insertions(+), 12 deletions(-)

diff --git a/CHANGELOG b/CHANGELOG
index c9ddcc7..c4485b2 100644
--- a/CHANGELOG
+++ b/CHANGELOG
@@ -1,3 +1,5 @@
+* Do not browser sniff when forking `unmark` function in selector suite. Instead use a proper test - PROPERTIES_ATTRIBUTES_MAP. (kangax)
+
 * Do not use short-hand element methods notation (@element.getStyle() -> Element.getStyle(@element)) for performance reasons. Do not use `$A` and `Array.prototype.shift` when `Array.prototype.slice` can be used instead. (kangax)
 
 * `Prototype.Browser.Opera` now uses stronger inference and is determined by [[Class]] of `window.opera` being - "Opera". (kangax)
diff --git a/src/dom/selector.js b/src/dom/selector.js
index c8362b0..b9b8c0e 100644
--- a/src/dom/selector.js
+++ b/src/dom/selector.js
@@ -437,11 +437,33 @@ Object.extend(Selector, {
       return nodes;
     },
     
-    unmark: function(nodes) {
-      for (var i = 0, node; node = nodes[i]; i++)
-        node._countedByPrototype = undefined;    
-      return nodes;  
-    },
+    unmark: (function(){
+      
+      // IE improperly serializes _countedByPrototype in (inner|outer)HTML
+      // due to node properties being mapped directly to attributes
+      var PROPERTIES_ATTRIBUTES_MAP = (function(){
+        var el = document.createElement('div'), 
+            isBuggy = false,
+            propName = '_countedByPrototype',
+            value = 'x'
+        el[propName] = value;
+        isBuggy = (el.getAttribute(propName) === value);
+        el = null;
+        return isBuggy;
+      });
+      
+      return PROPERTIES_ATTRIBUTES_MAP ?
+        function(nodes) {
+          for (var i = 0, node; node = nodes[i]; i++)
+            node.removeAttribute('_countedByPrototype');
+          return nodes;
+        } :
+        function(nodes) {
+          for (var i = 0, node; node = nodes[i]; i++)
+            node._countedByPrototype = void 0;
+          return nodes;
+        } 
+    })(),
 
     // mark each child node with its position (for nth calls)
     // "ofType" flag indicates whether we're indexing for nth-of-type
@@ -831,13 +853,6 @@ if (Prototype.Browser.IE) {
       for (var i = 0, node; node = b[i]; i++)
         if (node.tagName !== "!") a.push(node);
       return a;
-    },
-    
-    // IE improperly serializes _countedByPrototype in (inner|outer)HTML.
-    unmark: function(nodes) {
-      for (var i = 0, node; node = nodes[i]; i++)
-        node.removeAttribute('_countedByPrototype');
-      return nodes;  
     }
   });  
 }