From c8072f2f4adb1ee46340d0e4c74ca2637e3da811 Mon Sep 17 00:00:00 2001 From: Adrian Madrid Date: Tue, 6 Jan 2009 17:14:45 -0700 Subject: [PATCH] Added safety check for queries with unknown parameters. The idea came when I used :order instead of :sort and it silently _failed_ to work as expected ;-) --- lib/mongo/collection.rb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/mongo/collection.rb b/lib/mongo/collection.rb index ef97a07..a6e2c5a 100644 --- a/lib/mongo/collection.rb +++ b/lib/mongo/collection.rb @@ -43,7 +43,11 @@ module XGen def find(selector={}, options={}) fields = options.delete(:fields) fields = nil if fields && fields.empty? - @db.query(@name, Query.new(selector, fields, options[:offset] || 0, options[:limit] || 0, options[:sort])) + offset = options.delete(:offset) || 0 + limit = options.delete(:limit) || 0 + sort = options.delete(:sort) + raise RuntimeError, "Unknown options [#{options.inspect}]" unless options.empty? + @db.query(@name, Query.new(selector, fields, offset, limit, sort)) end # Insert +objects+, which are hashes.