From a3db5e6924699bef7421a052f172767d32d00fc5 Mon Sep 17 00:00:00 2001
From: Jim Menard <jim@10gen.com>
Date: Tue, 16 Dec 2008 06:57:13 -0500
Subject: [PATCH] cleanup; raise different for known but unimplemented types

---
 lib/mongo/util/bson.rb | 24 +++++++++++++-----------
 1 file changed, 13 insertions(+), 11 deletions(-)

diff --git a/lib/mongo/util/bson.rb b/lib/mongo/util/bson.rb
index 82af042..8f38322 100644
--- a/lib/mongo/util/bson.rb
+++ b/lib/mongo/util/bson.rb
@@ -3,28 +3,28 @@ require 'mongo/util/ordered_hash'
 require 'mongo/objectid'
 
 # See http://github.com/10gen/mongo/tree/master/db/jsobj.h
-# and 
 
 class BSON
 
-  EOO = 0                       # x
-  MAXKEY = -1                   # x
-  NUMBER = 1                    # x t
-  STRING = 2                    # x t
-  OBJECT = 3                    # x t
+  MINKEY = -1
+  EOO = 0
+  NUMBER = 1
+  STRING = 2
+  OBJECT = 3
   ARRAY = 4
   BINARY = 5
   UNDEFINED = 6
-  OID = 7                       # x
-  BOOLEAN = 8                   # x t
-  DATE = 9                      # x t
-  NULL = 10                     # x t
+  OID = 7
+  BOOLEAN = 8
+  DATE = 9
+  NULL = 10
   REGEX = 11
   REF = 12
   CODE = 13
   SYMBOL = 14
   CODE_W_SCOPE = 15
   NUMBER_INT = 16
+  MAXKEY = 127
 
   def self.serialize_cstr(buf, val)
     buf.put_array(val.to_s.unpack("C*") + [0])
@@ -67,8 +67,10 @@ class BSON
         serialize_date_element(@buf, k, v)
       when NULL
         serialize_null_element(@buf, k)
+      when BINARY, UNDEFINED, REF, SYMBOL, CODE_W_SCOPE
+        raise "unimplemented type #{type}"
       else
-        raise "Unhandled Type #{type}"
+        raise "unhandled type #{type}"
       end
     }
     serialize_eoo_element(@buf)