From 8fbf3ba859010660344c63fe5559b9a565e9b249 Mon Sep 17 00:00:00 2001
From: Steve Conover <sconover@gmail.com>
Date: Mon, 28 Feb 2011 14:39:59 -0800
Subject: [PATCH] newline at 50 characters

---
 spec/suites/TrivialNodeReporterSpec.js | 54 +++++++++++++++++++++++---
 src/node/TrivialNodeReporter.js        | 25 ++++++++++--
 2 files changed, 69 insertions(+), 10 deletions(-)

diff --git a/spec/suites/TrivialNodeReporterSpec.js b/spec/suites/TrivialNodeReporterSpec.js
index 2140a13..67de73a 100644
--- a/spec/suites/TrivialNodeReporterSpec.js
+++ b/spec/suites/TrivialNodeReporterSpec.js
@@ -11,6 +11,31 @@ describe("TrivialNodeReporter", function() {
   
   var newline = "\n";
   
+  var passingSpec = {
+    results: function(){
+      return {passed:function(){return true;}};
+    }
+  };
+  
+  var failingSpec = {
+    results: function(){
+      return {passed:function(){return false;}};
+    }
+  };
+  
+  function repeatedlyInvoke(f, times) {
+    for(var i=0; i<times; i++) f(times+1);
+  }
+  
+  function repeat(thing, times) {
+    var arr = [];
+    for(var i=0; i<times; i++) arr.push(thing);
+    return arr;
+  }
+  
+  var fiftyRedFs = repeat(red("F"), 50).join("");
+  var fiftyGreenDots = repeat(green("."), 50).join("");
+  
   beforeEach(function() {
     this.fakeSys = (function(){
       var output = "";
@@ -49,13 +74,7 @@ describe("TrivialNodeReporter", function() {
   describe('A Test Run', function(){
     
     describe('A spec runs', function(){
-    
       it("prints a green dot if the spec passes", function(){
-        var passingSpec = {
-          results: function(){
-            return {passed:function(){return true;}};
-          }
-        };
         this.reporter.reportSpecResults(passingSpec);
 
         expect(this.fakeSys.getOutput()).toEqual(
@@ -75,7 +94,30 @@ describe("TrivialNodeReporter", function() {
           red("F")
         );
       });
+    });
     
+    
+    describe('many specs run', function(){
+      it("starts a new line every 50 specs", function(){
+        var self = this;
+        repeatedlyInvoke(function(){self.reporter.reportSpecResults(failingSpec);}, 49);
+
+        expect(this.fakeSys.getOutput()).
+          toEqual(repeat(red("F"), 49).join(""));
+        
+        repeatedlyInvoke(function(){self.reporter.reportSpecResults(failingSpec);}, 3);
+        
+        expect(this.fakeSys.getOutput()).
+          toEqual(fiftyRedFs + newline + 
+                  red("F") + red("F"));
+          
+        repeatedlyInvoke(function(){self.reporter.reportSpecResults(failingSpec);}, 48);
+        repeatedlyInvoke(function(){self.reporter.reportSpecResults(passingSpec);}, 2);
+        expect(this.fakeSys.getOutput()).
+          toEqual(fiftyRedFs + newline + 
+                  fiftyRedFs + newline + 
+                  green(".") + green("."));
+      });      
     });
 
   });
diff --git a/src/node/TrivialNodeReporter.js b/src/node/TrivialNodeReporter.js
index 4155922..3451178 100644
--- a/src/node/TrivialNodeReporter.js
+++ b/src/node/TrivialNodeReporter.js
@@ -7,22 +7,39 @@ jasmine.TrivialNodeReporter = function(sys) {
     none: '\033[0m'
   };
   
+  var defaultColumnsPerLine = 50;
+  
   function coloredStr(color, str) { return ansi[color] + str + ansi.none; }
   
   function greenStr(str)  { return coloredStr("green", str); }
   function redStr(str)    { return coloredStr("red", str); }
   function yellowStr(str) { return coloredStr("yellow", str); }
   
-  function greenDot(str)  { sys.print(greenStr(".")); }
-  function redF(str)      { sys.print(redStr("F")); }
-  function newline(str)   { sys.print("\n"); }
+  function greenDot()  { sys.print(greenStr(".")); }
+  function redF()      { sys.print(redStr("F")); }
+  function newline()   { sys.print("\n"); }
+  
+  
+  function lineEnder(columnsPerLine) {
+    var columnsSoFar = 0;
+    return function() {
+      columnsSoFar += 1;
+      if (columnsSoFar == columnsPerLine) {
+        newline();
+        columnsSoFar = 0;
+      }
+    };
+  }
+  
+  var startNewLineIfNecessary = lineEnder(defaultColumnsPerLine);
   
   this.reportSpecResults = function(spec) {
     if (spec.results().passed()) {
       greenDot();
     } else {
       redF();
-    }    
+    } 
+    startNewLineIfNecessary();   
   };
 };