From d7115caad66e99eee5576d6f18d67b17b1fd4dc5 Mon Sep 17 00:00:00 2001 From: ltackett Date: Fri, 29 Apr 2011 14:57:06 -0700 Subject: [PATCH] :focus should not use shorthand border property, since it only need to change the border-color Closes GH-367. --- doc-src/content/CHANGELOG.markdown | 1 + frameworks/blueprint/stylesheets/blueprint/_form.scss | 2 +- test/fixtures/stylesheets/blueprint/css/screen.css | 2 +- .../stylesheets/blueprint/css/single-imports/form.css | 2 +- .../stylesheets/blueprint/css/single-imports/reset.css | 8 +------- 5 files changed, 5 insertions(+), 10 deletions(-) diff --git a/doc-src/content/CHANGELOG.markdown b/doc-src/content/CHANGELOG.markdown index 600a832e..05de4694 100644 --- a/doc-src/content/CHANGELOG.markdown +++ b/doc-src/content/CHANGELOG.markdown @@ -25,6 +25,7 @@ The Documentation for the [latest preview release](http://beta.compass-style.org * Fix absolute path detection on windows. * Fix the mime type returned for inline svg images. * Allow multiple transitions in the CSS3 `transition` mixin. +* The Blueprint `:focus` styles no longer clobbers cascade-based overrides unnecessarily. 0.11.3 (06/11/2011) ------------------- diff --git a/frameworks/blueprint/stylesheets/blueprint/_form.scss b/frameworks/blueprint/stylesheets/blueprint/_form.scss index 39a3398a..25ce4560 100644 --- a/frameworks/blueprint/stylesheets/blueprint/_form.scss +++ b/frameworks/blueprint/stylesheets/blueprint/_form.scss @@ -59,7 +59,7 @@ background-color:#fff; border: 1px solid $unfocused-border-color; &:focus { - border: 1px solid $focus-border-color; + border-color: $focus-border-color; } } select { background-color:#fff; border-width:1px; border-style:solid; } diff --git a/test/fixtures/stylesheets/blueprint/css/screen.css b/test/fixtures/stylesheets/blueprint/css/screen.css index eed89ea9..280eab5d 100644 --- a/test/fixtures/stylesheets/blueprint/css/screen.css +++ b/test/fixtures/stylesheets/blueprint/css/screen.css @@ -759,7 +759,7 @@ textarea { border: 1px solid #bbbbbb; } input.text:focus, input.title:focus, input[type=email]:focus, input[type=text]:focus, input[type=password]:focus, textarea:focus { - border: 1px solid #666666; } + border-color: #666666; } select { background-color: #fff; diff --git a/test/fixtures/stylesheets/blueprint/css/single-imports/form.css b/test/fixtures/stylesheets/blueprint/css/single-imports/form.css index 13c1bd2a..a61ac8f3 100644 --- a/test/fixtures/stylesheets/blueprint/css/single-imports/form.css +++ b/test/fixtures/stylesheets/blueprint/css/single-imports/form.css @@ -30,7 +30,7 @@ form.bp textarea { border: 1px solid #bbbbbb; } form.bp input.text:focus, form.bp input.title:focus, form.bp input[type=email]:focus, form.bp input[type=text]:focus, form.bp input[type=password]:focus, form.bp textarea:focus { - border: 1px solid #666666; } + border-color: #666666; } form.bp select { background-color: #fff; border-width: 1px; diff --git a/test/fixtures/stylesheets/blueprint/css/single-imports/reset.css b/test/fixtures/stylesheets/blueprint/css/single-imports/reset.css index 63bd86a7..357295b2 100644 --- a/test/fixtures/stylesheets/blueprint/css/single-imports/reset.css +++ b/test/fixtures/stylesheets/blueprint/css/single-imports/reset.css @@ -3,13 +3,7 @@ html { padding: 0; border: 0; } -.bp-reset-element, body, h1, h2, h3, h4, h5, h6, article, aside, dialog, figure, footer, header, hgroup, nav, section, blockquote, q, th, td, caption, table, -div, span, object, iframe, p, -pre, a, abbr, acronym, address, -code, del, dfn, em, img, -dl, dt, dd, ol, ul, li, fieldset, -form, label, legend, -caption, tbody, tfoot, thead, tr { +.bp-reset-element, body, h1, h2, h3, h4, h5, h6, article, aside, dialog, figure, footer, header, hgroup, nav, section, blockquote, q, th, td, caption, table, div, span, object, iframe, p, pre, a, abbr, acronym, address, code, del, dfn, em, img, dl, dt, dd, ol, ul, li, fieldset, form, label, legend, caption, tbody, tfoot, thead, tr { margin: 0; padding: 0; border: 0;